Step 6 filter devices for platform (#153)

* Filter valid devices based on platform

* Fix existing test cases and auto gen rubocop todos.

* Explicitly check device types.

* Test platform device type mapping.

* Improve exception logging.

* Improve result_string and run_and_handle_portal_function function names.

* Update rubocop gem version and regenerate rubocop todos.

* Typo fix.

* Make Xcode.parse_xcodebuild_version_out public. (+1 squashed commit)
Squashed commits:
[b2be9bb] Use Apple Development and Distribution codesign identity from Xcode 13 in case of Xcode managed signing.

* Install bundler during check workflow.

* Skipp test_xcode_managed above Xcode 12.

* Revert "Make Xcode.parse_xcodebuild_version_out public. (+1 squashed commit)"

This reverts commit ce17c93.

* Upgrade to bundler 2.2.24.

Co-authored-by: Bence Zsigmond Nagy <nbzs1001@gmail.com>

Author: godrei

.rubocop_todo.yml

@@ -1,95 +1,127 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2021-02-24 19:09:31 +0100 using RuboCop version 0.61.1.
+# on 2021-07-21 08:44:28 UTC using RuboCop version 1.18.3.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 42
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
-# SupportedHashRocketStyles: key, separator, table
-# SupportedColonStyles: key, separator, table
-# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
-Layout/AlignHash:
-  Exclude:
-    - 'lib/autoprovision/portal/app_client.rb'
-
-# Offense count: 15
+# Offense count: 13
 # Cop supports --auto-correct.
 Layout/EmptyLineAfterGuardClause:
   Exclude:
     - 'lib/autoprovision/auth_data.rb'
     - 'lib/autoprovision/certificate_helper.rb'
     - 'lib/autoprovision/device.rb'
     - 'lib/autoprovision/portal/app_client.rb'
-    - 'lib/autoprovision/portal/common.rb'
     - 'lib/autoprovision/project_helper.rb'
     - 'log/log.rb'
     - 'params.rb'
 
-# Offense count: 1
+# Offense count: 42
 # Cop supports --auto-correct.
-Layout/EmptyLinesAroundExceptionHandlingKeywords:
+# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
+# SupportedHashRocketStyles: key, separator, table
+# SupportedColonStyles: key, separator, table
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Layout/HashAlignment:
   Exclude:
-    - 'main.rb'
+    - 'lib/autoprovision/portal/app_client.rb'
 
-# Offense count: 3
+# Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: Width, IgnoredPatterns.
 Layout/IndentationWidth:
   Exclude:
     - 'log/log.rb'
-    - 'main.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: final_newline, final_blank_line
-Layout/TrailingBlankLines:
+# Configuration parameters: AllowInHeredoc.
+Layout/TrailingWhitespace:
   Exclude:
-    - 'main.rb'
+    - 'spec/device_client_spec.rb'
 
-# Offense count: 32
+# Offense count: 29
+# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
 Metrics/AbcSize:
-  Max: 65
+  Max: 64
 
 # Offense count: 2
-# Configuration parameters: CountComments, ExcludedMethods.
-# ExcludedMethods: refine
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+# IgnoredMethods: refine
 Metrics/BlockLength:
-  Max: 38
+  Max: 78
 
 # Offense count: 4
-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
   Max: 331
 
-# Offense count: 16
+# Offense count: 17
+# Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
-  Max: 18
+  Max: 22
 
 # Offense count: 35
-# Configuration parameters: CountComments, ExcludedMethods.
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
 Metrics/MethodLength:
   Max: 61
 
 # Offense count: 2
-# Configuration parameters: CountKeywordArgs.
+# Configuration parameters: CountKeywordArgs, MaxOptionalParameters.
 Metrics/ParameterLists:
   Max: 8
 
-# Offense count: 13
+# Offense count: 16
+# Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
-  Max: 22
+  Max: 24
+
+# Offense count: 1
+# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
+# AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to
+Naming/MethodParameterName:
+  Exclude:
+    - 'lib/autoprovision/portal/common.rb'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredName.
+Naming/RescuedExceptionsVariableName:
+  Exclude:
+    - 'lib/autoprovision/portal/common.rb'
+    - 'lib/autoprovision/portal/device_client.rb'
+    - 'lib/autoprovision/portal/profile_client.rb'
+    - 'lib/autoprovision/profile_helper.rb'
+    - 'step.rb'
+
+# Offense count: 32
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: separated, grouped
+Style/AccessorGrouping:
+  Exclude:
+    - 'lib/autoprovision/auth_data.rb'
+    - 'lib/autoprovision/certificate_helper.rb'
+    - 'lib/autoprovision/certificate_info.rb'
+    - 'lib/autoprovision/device.rb'
+    - 'lib/autoprovision/profile_info.rb'
+    - 'lib/autoprovision/project_helper.rb'
+    - 'params.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
 Style/BlockComments:
   Exclude:
     - 'spec/spec_helper.rb'
 
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/CaseLikeIf:
+  Exclude:
+    - 'lib/autoprovision/portal/app_client.rb'
+
 # Offense count: 1
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
@@ -103,7 +135,41 @@ Style/IfUnlessModifier:
     - 'lib/autoprovision/certificate_helper.rb'
     - 'lib/autoprovision/profile_helper.rb'
 
-# Offense count: 7
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoredMethods.
+Style/MethodCallWithoutArgsParentheses:
+  Exclude:
+    - 'spec/device_client_spec.rb'
+
+# Offense count: 3
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: respond_to_missing?
+Style/OptionalBooleanParameter:
+  Exclude:
+    - 'lib/autoprovision/portal/profile_client.rb'
+    - 'lib/autoprovision/profile_helper.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/RedundantAssignment:
+  Exclude:
+    - 'lib/autoprovision/device.rb'
+    - 'lib/autoprovision/utils.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RedundantFileExtensionInRequire:
+  Exclude:
+    - 'spec/project_helper_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/RedundantSelfAssignment:
+  Exclude:
+    - 'lib/autoprovision/portal/device_client.rb'
+
+# Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: implicit, explicit
@@ -112,19 +178,38 @@ Style/RescueStandardError:
     - 'lib/autoprovision/portal/device_client.rb'
     - 'lib/autoprovision/portal/profile_client.rb'
     - 'lib/autoprovision/profile_helper.rb'
-    - 'main.rb'
     - 'step.rb'
 
-# Offense count: 4
+# Offense count: 6
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
-# SupportedStyles: single_quotes, double_quotes
-Style/StringLiterals:
+# Configuration parameters: Mode.
+Style/StringConcatenation:
   Exclude:
-    - 'main.rb'
+    - 'lib/autoprovision/auth_helper.rb'
+    - 'lib/autoprovision/keychain_helper.rb'
+    - 'lib/autoprovision/profile_helper.rb'
+    - 'lib/autoprovision/project_helper.rb'
+    - 'spec/project_helper_spec.rb'
 
-# Offense count: 235
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleForMultiline.
+# SupportedStylesForMultiline: comma, consistent_comma, no_comma
+Style/TrailingCommaInArrayLiteral:
+  Exclude:
+    - 'spec/device_client_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: WordRegex.
+# SupportedStyles: percent, brackets
+Style/WordArray:
+  EnforcedStyle: percent
+  MinSize: 3
+
+# Offense count: 56
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
-Metrics/LineLength:
+Layout/LineLength:
   Max: 225

Gemfile

@@ -7,5 +7,5 @@ gem 'xcodeproj'
 
 group :test do
   gem 'rspec'
-  gem 'rubocop', '0.61.1'
+  gem 'rubocop', '~> 1.18'
 end

Gemfile.lock

@@ -139,7 +139,6 @@ GEM
     http-cookie (1.0.4)
       domain_name (~> 0.5)
     httpclient (2.8.3)
-    jaro_winkler (1.5.4)
     jmespath (1.4.0)
     json (2.5.1)
     jwt (2.2.3)
@@ -153,13 +152,13 @@ GEM
     openssl (2.2.0)
     os (1.1.1)
     parallel (1.20.1)
-    parser (3.0.1.1)
+    parser (3.0.2.0)
       ast (~> 2.4.1)
     plist (3.6.0)
-    powerpack (0.1.3)
     public_suffix (4.0.6)
     rainbow (3.0.0)
     rake (13.0.3)
+    regexp_parser (2.1.1)
     representable (3.1.1)
       declarative (< 0.1.0)
       trailblazer-option (>= 0.1.1, < 0.2.0)
@@ -180,14 +179,17 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
     rspec-support (3.10.2)
-    rubocop (0.61.1)
-      jaro_winkler (~> 1.5.1)
+    rubocop (1.18.3)
       parallel (~> 1.10)
-      parser (>= 2.5, != 2.5.1.1)
-      powerpack (~> 0.1)
+      parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml
+      rubocop-ast (>= 1.7.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.4.0)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.8.0)
+      parser (>= 3.0.1.1)
     ruby-progressbar (1.11.0)
     ruby2_keywords (0.0.4)
     rubyzip (2.3.0)
@@ -234,8 +236,8 @@ DEPENDENCIES
   openssl
   plist
   rspec
-  rubocop (= 0.61.1)
+  rubocop (~> 1.18)
   xcodeproj
 
 BUNDLED WITH
-   1.17.3
+   2.2.24

bitrise.yml

@@ -10,6 +10,7 @@ workflows:
         - content: |-
             #!/bin/bash
             set -e
+            gem install bundler -v 2.2.24 --force
             bundle install
     - script:
         title: rubocop