fix: negative balance displayed as positive

Author: denengineer

app/sources/src/stores/accounts.js

@@ -50,7 +50,8 @@ const accounts = {
         };
         result[balance].denominationsAvailable[denomination].toString = () => {
           return denominations.get.data[balance][denomination].stringify(amountAvailable, {
-            omitDirection: true,
+            omitDirection: false,
+            directionsShown: ['negative'],
           });
         };
 
@@ -60,7 +61,8 @@ const accounts = {
         };
         result[balance].denominationsPending[denomination].toString = () => {
           return denominations.get.data[balance][denomination].stringify(amountPending, {
-            omitDirection: true,
+            omitDirection: false,
+            directionsShown: ['negative'],
           });
         };
       });

app/sources/src/stores/denominations.js

@@ -30,10 +30,23 @@ const denominations = {
         round(number) {
           return round(number, this.precision, this.precisionMax);
         },
-        stringify(number, { omitDirection = false, omitSign = false } = {}) {
-          return `${omitDirection ? '' : number === 0 ? '' : number > 0 ? '+ ' : '- '}${
-            omitSign ? '' : `${this.sign} `
-          }${this.round(Math.abs(number))
+        stringify(
+          number,
+          { omitDirection = false, omitSign = false, directionsShown = ['positive', 'negative'] } = {},
+        ) {
+          return `${
+            omitDirection
+              ? ''
+              : number === 0
+              ? ''
+              : number > 0
+              ? directionsShown.includes('positive')
+                ? '+ '
+                : ''
+              : directionsShown.includes('negative')
+              ? '- '
+              : ''
+          }${omitSign ? '' : `${this.sign} `}${this.round(Math.abs(number))
             .toFixed(this.precisionMax || 1)
             .replace(/0+$/, '')
             .replace(/\.$/, '')}`;
@@ -47,10 +60,23 @@ const denominations = {
         round(number) {
           return round(number, this.precision, this.precisionMax);
         },
-        stringify(number, { omitDirection = false, omitSign = false } = {}) {
-          return `${omitDirection ? '' : number === 0 ? '' : number > 0 ? '+ ' : '- '}${
-            omitSign ? '' : `${this.sign} `
-          }${this.round(Math.abs(number))
+        stringify(
+          number,
+          { omitDirection = false, omitSign = false, directionsShown = ['positive', 'negative'] } = {},
+        ) {
+          return `${
+            omitDirection
+              ? ''
+              : number === 0
+              ? ''
+              : number > 0
+              ? directionsShown.includes('positive')
+                ? '+ '
+                : ''
+              : directionsShown.includes('negative')
+              ? '- '
+              : ''
+          }${omitSign ? '' : `${this.sign} `}${this.round(Math.abs(number))
             .toFixed(this.precisionMax || 1)
             .replace(/0+$/, '')
             .replace(/\.$/, '')}`;