Remove duplicate submission of x-app-* headers through signalr client (#11515)

[ysmoradi]

closes #11515

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Removed application version and platform headers from SignalR connections.

[coderabbitai]

Walkthrough

Removed duplicate emission of telemetry headers (X-App-Version and X-App-Platform) from SignalR hub connection setup. These headers are already added by HTTP client message handlers, eliminating redundant header transmission.

Changes

Cohort / File(s)	Summary
SignalR Header Configuration Cleanup src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Extensions/IClientCoreServiceCollectionExtensions.cs	Removed ITelemetryContext retrieval and duplicate X-App-Version and X-App-Platform header injection from SignalR hub connection options. Connection negotiation, transport, and message handling logic remain intact.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify that HTTP client message handlers correctly handle the removed headers
• Confirm no other SignalR connection setup relies on these headers being set at this location
• Validate that the removal resolves duplicate header transmission without breaking functionality

Poem

🐰 Headers doubled, now they're not,
One path for telemetry—the cleaner plot!
Duplicates gone, the signal runs true,
Cleaner, faster—hopping on through! 🚀

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "Remove duplicate submission of x-app-* headers through signalr client (#11515)" is a clear and concise description that accurately reflects the main change in the code. The title specifically identifies what was removed (duplicate x-app-* headers), where it was removed from (SignalR client), and references the associated issue number. A developer scanning the pull request history would immediately understand that this change addresses header duplication in SignalR communication.
Linked Issues Check	✅ Passed	The pull request successfully addresses the primary coding objective from issue #11515: eliminating duplicate sending of X-App-Version and X-App-Platform headers by removing the runtime emission of these telemetry-related headers from the SignalR hub connection setup. The raw summary confirms that the code retrieving ITelemetryContext and adding these headers has been deleted, directly resolving the duplicate header submission problem. The verification objective (#11515) is a non-coding testing task that is outside the scope of code review validation.
Out of Scope Changes Check	✅ Passed	All changes in this pull request are directly aligned with the stated objective of removing duplicate X-App-Version and X-App-Platform headers from SignalR client communication. The single modified file (IClientCoreServiceCollectionExtensions.cs) is the appropriate location for this change, and the alterations are focused solely on removing the header-setting code while preserving all other connection configuration. No unrelated modifications, refactoring, or feature changes are present in the changeset.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between e18d8df and e14fa7c.

📒 Files selected for processing (1)

• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Extensions/IClientCoreServiceCollectionExtensions.cs (0 hunks)

💤 Files with no reviewable changes (1)

• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Extensions/IClientCoreServiceCollectionExtensions.cs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: CodeQL analysis (csharp)
• GitHub Check: build and test

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull Request Overview

This pull request removes redundant header configuration from the SignalR hub connection setup. The removed code was explicitly adding X-App-Version and X-App-Platform headers to SignalR connection options, which is now unnecessary.

Key Changes:

• Removed 5 lines of code that manually added telemetry headers to SignalR connection options
• Simplified the SignalR connection configuration in IClientCoreServiceCollectionExtensions.cs