Skip to content

Conversation

@ysmoradi
Copy link
Member

closes #11518

@ysmoradi ysmoradi requested a review from Copilot October 30, 2025 15:31
@coderabbitai
Copy link

coderabbitai bot commented Oct 30, 2025

Warning

Rate limit exceeded

@ysmoradi has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 22 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between e18d8df and 31623c7.

📒 Files selected for processing (1)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/SignalR/AppHub.cs (0 hunks)
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes client app version checking from the SignalR hub connection logic. The version validation has been centralized in the ForceUpdateMiddleware, which handles HTTP requests globally.

  • Removed CheckClientAppVersion() method from AppHub class
  • Removed the method call from OnConnectedAsync()

@ysmoradi ysmoradi requested review from msynk and removed request for msynk October 30, 2025 15:46
@msynk msynk merged commit efd5d7e into bitfoundation:develop Oct 30, 2025
8 of 9 checks passed
@ysmoradi ysmoradi deleted the 11518 branch November 2, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redundant client version check in AppHub

2 participants