Skip to content

Conversation

@ysmoradi
Copy link
Member

closes #11520

@ysmoradi ysmoradi requested a review from Copilot October 30, 2025 15:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the configuration keys for S3 storage credentials in the development settings. The change renames the MinIO-specific configuration keys to more generic S3 naming to better reflect the abstraction level.

  • Renamed minio-rootPassword to s3-rootPassword
  • Renamed minio__Comment to s3__Comment

@coderabbitai
Copy link

coderabbitai bot commented Oct 30, 2025

Warning

Rate limit exceeded

@ysmoradi has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 34 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between e18d8df and 6bd3ee8.

📒 Files selected for processing (1)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/appsettings.Development.json (1 hunks)

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ysmoradi ysmoradi requested a review from msynk October 30, 2025 15:46
@msynk msynk changed the title Change root password parameter name to reflect resource name change (#11520) Change S3's root password setting name to reflect resource name change (#11520) Oct 30, 2025
@msynk msynk merged commit 228befd into bitfoundation:develop Oct 30, 2025
9 checks passed
@ysmoradi ysmoradi deleted the 11520 branch November 2, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Aspire app host minio resource rename not reflected in configuration

2 participants