Skip to content

Conversation

@ysmoradi
Copy link
Member

@ysmoradi ysmoradi commented Oct 30, 2025

closes #11525

Summary by CodeRabbit

  • Chores
    • Removed Android package references from the project configuration and centralized package version management.

@ysmoradi ysmoradi requested a review from Copilot October 30, 2025 15:11
@coderabbitai
Copy link

coderabbitai bot commented Oct 30, 2025

Walkthrough

Removed two unnecessary Xamarin.AndroidX.SavedState package references from the MAUI boilerplate project's Android dependencies and their corresponding package version entries, streamlining dependency management.

Changes

Cohort / File(s) Summary
Android Dependency Cleanup
src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Maui/Boilerplate.Client.Maui.csproj
Removed two PackageReference entries conditioned on the notification flag: Xamarin.AndroidX.SavedState and Xamarin.AndroidX.SavedState.SavedState.Ktx
Package Version Registry
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props
Removed two PackageVersion entries for Xamarin.AndroidX.SavedState (v1.3.2) and Xamarin.AndroidX.SavedState.SavedState.Ktx (v1.3.2)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Straightforward dependency removal with no logic changes
  • Simple deletion of package references across two configuration files
  • High confidence that changes are complete and consistent between both files

Poem

🐰 With ears held high and nose held keen,
I've spotted bloat that shouldn't be seen—
Two SavedState packages, no longer our friend,
Hopped right out, dependencies mend! 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "Remove Xamarin.AndroidX.* from project (#11525)" directly and clearly describes the main change in the pull request. It is specific about what is being removed (Xamarin.AndroidX packages) and where (from the project), making it easy for a teammate scanning history to understand the primary purpose. The title is concise, avoids vague terms, and accurately reflects the core objective of the changeset.
Linked Issues Check ✅ Passed The pull request directly addresses the objective stated in linked issue #11525. The code changes remove the two unnecessary Xamarin.AndroidX.SavedState.* packages (Xamarin.AndroidX.SavedState and Xamarin.AndroidX.SavedState.SavedState.Ktx) from both the project file (.csproj) and the central package versions file (Directory.Packages.props), which fulfills the requirement to identify and remove these unnecessary dependencies from the project.
Out of Scope Changes Check ✅ Passed All changes in the pull request are directly scoped to the stated objective of removing Xamarin.AndroidX.SavedState.* packages from project dependencies. The modifications consist solely of removing the two PackageReference entries from the project file and the two corresponding PackageVersion entries from the central package versions file, with surrounding configurations and other Android-related entries remaining unchanged as expected.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between e18d8df and 070acbb.

📒 Files selected for processing (2)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Maui/Boilerplate.Client.Maui.csproj (0 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props (0 hunks)
💤 Files with no reviewable changes (2)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Maui/Boilerplate.Client.Maui.csproj
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build and test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes explicit dependencies on Xamarin.AndroidX.SavedState and Xamarin.AndroidX.SavedState.SavedState.Ktx packages from the notification feature configuration.

Key Changes

  • Removed Xamarin.AndroidX.SavedState package version declaration from central package management
  • Removed Xamarin.AndroidX.SavedState.SavedState.Ktx package version declaration from central package management
  • Removed corresponding package references from the MAUI client project

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props Removed version declarations for two Xamarin.AndroidX.SavedState packages
src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Maui/Boilerplate.Client.Maui.csproj Removed package references for two Xamarin.AndroidX.SavedState packages

@ysmoradi ysmoradi requested a review from msynk October 30, 2025 15:45
@msynk msynk merged commit 0763d01 into bitfoundation:develop Oct 30, 2025
9 checks passed
@ysmoradi ysmoradi deleted the 11525 branch November 2, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary Xamarin.AndroidX.SavedState packages included

2 participants