-
-
Notifications
You must be signed in to change notification settings - Fork 253
Remove Xamarin.AndroidX.* from project (#11525) #11526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughRemoved two unnecessary Xamarin.AndroidX.SavedState package references from the MAUI boilerplate project's Android dependencies and their corresponding package version entries, streamlining dependency management. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Knowledge base: Disabled due to 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes explicit dependencies on Xamarin.AndroidX.SavedState and Xamarin.AndroidX.SavedState.SavedState.Ktx packages from the notification feature configuration.
Key Changes
- Removed
Xamarin.AndroidX.SavedStatepackage version declaration from central package management - Removed
Xamarin.AndroidX.SavedState.SavedState.Ktxpackage version declaration from central package management - Removed corresponding package references from the MAUI client project
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props | Removed version declarations for two Xamarin.AndroidX.SavedState packages |
| src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Maui/Boilerplate.Client.Maui.csproj | Removed package references for two Xamarin.AndroidX.SavedState packages |
closes #11525
Summary by CodeRabbit