Skip to content

Rename PreserveCalloutWidh parameter to FixedCalloutWidth in callouts (#11507) #11510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

Rename PreserveCalloutWidh parameter to FixedCalloutWidth in callouts (#11507) #11510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BlazorUI/Bit.BlazorUI/Components/Buttons/MenuButton/BitMenuButton.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,7 @@ await _js.BitCalloutToggleCallout(
headerId: "",
footerId: "",
setCalloutWidth: true,
preserveCalloutWidth: false,
fixedCalloutWidth: false,
maxWindowWidth: 0);
}

Expand Down
2 changes: 1 addition & 1 deletion ...BlazorUI/Bit.BlazorUI/Components/Inputs/CircularTimePicker/BitCircularTimePicker.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,7 @@ await _js.BitCalloutToggleCallout(
headerId: "",
footerId: "",
setCalloutWidth: false,
preserveCalloutWidth: false,
fixedCalloutWidth: false,
maxWindowWidth: 0);
}

Expand Down
2 changes: 1 addition & 1 deletion src/BlazorUI/Bit.BlazorUI/Components/Inputs/DatePicker/BitDatePicker.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1416,7 +1416,7 @@ private async Task<bool> ToggleCallout()
headerId: "",
footerId: "",
setCalloutWidth: false,
preserveCalloutWidth: false,
fixedCalloutWidth: false,
maxWindowWidth: MAX_WIDTH);
}

Expand Down
2 changes: 1 addition & 1 deletion src/BlazorUI/Bit.BlazorUI/Components/Inputs/DateRangePicker/BitDateRangePicker.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1939,7 +1939,7 @@ private async Task<bool> ToggleCallout()
headerId: "",
footerId: "",
setCalloutWidth: false,
preserveCalloutWidth: false,
fixedCalloutWidth: false,
maxWindowWidth: MAX_WIDTH);
}

Expand Down
2 changes: 1 addition & 1 deletion src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1187,7 +1187,7 @@ private async Task ToggleCallout()
headerId: CalloutHeaderTemplate is not null ? _headerId : "",
footerId: CalloutFooterTemplate is not null ? _footerId : "",
setCalloutWidth: PreserveCalloutWidth is false,
preserveCalloutWidth: false,
fixedCalloutWidth: false,
maxWindowWidth: 0);
}

Expand Down
2 changes: 1 addition & 1 deletion src/BlazorUI/Bit.BlazorUI/Components/Inputs/SearchBox/BitSearchBox.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ await _js.BitCalloutToggleCallout(
headerId: string.Empty,
footerId: string.Empty,
setCalloutWidth: false,
preserveCalloutWidth: false,
fixedCalloutWidth: false,
maxWindowWidth: 0);
}

Expand Down
2 changes: 1 addition & 1 deletion src/BlazorUI/Bit.BlazorUI/Components/Inputs/TimePicker/BitTimePicker.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ await _js.BitCalloutToggleCallout(
headerId: string.Empty,
footerId: string.Empty,
setCalloutWidth: true,
preserveCalloutWidth: false,
fixedCalloutWidth: false,
maxWindowWidth: 0);
}

Expand Down
2 changes: 1 addition & 1 deletion src/BlazorUI/Bit.BlazorUI/Components/Navs/Breadcrumb/BitBreadcrumb.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ await _js.BitCalloutToggleCallout(
headerId: "",
footerId: "",
setCalloutWidth: false,
preserveCalloutWidth: false,
fixedCalloutWidth: false,
maxWindowWidth: 0);
}

Expand Down
2 changes: 1 addition & 1 deletion src/BlazorUI/Bit.BlazorUI/Components/Navs/DropMenu/BitDropMenu.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ await _js.BitCalloutToggleCallout(
headerId: "",
footerId: "",
setCalloutWidth: false,
preserveCalloutWidth: false,
fixedCalloutWidth: false,
maxWindowWidth: 0);
}

Expand Down
14 changes: 7 additions & 7 deletions src/BlazorUI/Bit.BlazorUI/Components/Surfaces/Callout/BitCallout.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ public partial class BitCallout : BitComponentBase
/// </summary>
[Parameter] public BitDropDirection? Direction { get; set; }

/// <summary>
/// Forces the callout to preserve its component's original width.
/// </summary>
[Parameter] public bool FixedCalloutWidth { get; set; }

/// <summary>
/// The id of the footer element that renders at the end of the scrolling container of the callout contnet.
/// </summary>
Expand Down Expand Up @@ -79,12 +84,7 @@ public partial class BitCallout : BitComponentBase
[Parameter] public EventCallback<bool> OnToggle { get; set; }

/// <summary>
/// Forces the callout to preserve its component's original width.
/// </summary>
[Parameter] public bool PreserveCalloutWidth { get; set; }

/// <summary>
/// Forces the callout to set its content container width while openning based on the available space and actual content.
/// Forces the callout to set its content container width while opening based on the available space and actual content.
/// </summary>
[Parameter] public bool SetCalloutWidth { get; set; }

Expand Down Expand Up @@ -205,7 +205,7 @@ await _js.BitCalloutToggleCallout(
headerId: HeaderId ?? "",
footerId: FooterId ?? "",
setCalloutWidth: SetCalloutWidth,
preserveCalloutWidth: PreserveCalloutWidth,
fixedCalloutWidth: FixedCalloutWidth,
maxWindowWidth: MaxWindowWidth ?? 0);

await OnToggle.InvokeAsync(IsOpen);
Expand Down
37 changes: 19 additions & 18 deletions src/BlazorUI/Bit.BlazorUI/Extensions/JsInterop/CalloutsJsRuntimeExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,26 +20,27 @@ internal static class CalloutsJsRuntimeExtensions
string headerId,
string footerId,
bool setCalloutWidth,
bool preserveCalloutWidth,
bool fixedCalloutWidth,
int maxWindowWidth) where T : class
{
return jsRuntime.Invoke<bool>("BitBlazorUI.Callouts.toggle",
dotnetObj,
componentId,
component,
calloutId,
callout,
isCalloutOpen,
responsiveMode,
dropDirection,
isRtl,
scrollContainerId,
scrollOffset,
headerId,
footerId,
setCalloutWidth,
preserveCalloutWidth,
maxWindowWidth);
return jsRuntime.Invoke<bool>(
"BitBlazorUI.Callouts.toggle",
dotnetObj,
componentId,
component,
calloutId,
callout,
isCalloutOpen,
responsiveMode,
dropDirection,
isRtl,
scrollContainerId,
scrollOffset,
headerId,
footerId,
setCalloutWidth,
fixedCalloutWidth,
maxWindowWidth);
}

internal static ValueTask BitCalloutClearCallout(this IJSRuntime jsRuntime, string calloutId)
Expand Down
4 changes: 2 additions & 2 deletions src/BlazorUI/Bit.BlazorUI/Scripts/Callouts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ namespace BitBlazorUI {
headerId: string,
footerId: string,
setCalloutWidth: boolean,
preserveCalloutWidth: boolean,
fixedCalloutWidth: boolean,
maxWindowWidth: number,
) {
component ??= document.getElementById(componentId);
Expand Down Expand Up @@ -95,7 +95,7 @@ namespace BitBlazorUI {
callout.style.width = width + 'px';
calloutWidth = width;
}
if (preserveCalloutWidth) {
if (fixedCalloutWidth) {
let width = Math.min(componentWidth, calloutWidth);
callout.style.width = width + 'px';
calloutWidth = width;
Expand Down
16 changes: 8 additions & 8 deletions ...t/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Surfaces/Callout/BitCalloutDemo.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,13 @@ public partial class BitCalloutDemo
Href = "#drop-direction-enum"
},
new()
{
Name = "FixedCalloutWidth",
Type = "bool",
DefaultValue = "false",
Description = "Forces the callout to preserve its component's original width."
},
new()
{
Name = "FooterId",
Type = "string?",
Expand Down Expand Up @@ -93,18 +100,11 @@ public partial class BitCalloutDemo
Description = "The callback that is called when the callout opens or closes."
},
new()
{
Name = "PreserveCalloutWidth",
Type = "bool",
DefaultValue = "false",
Description = "Forces the callout to preserve its component's original width."
},
new()
{
Name = "SetCalloutWidth",
Type = "bool",
DefaultValue = "false",
Description = "Forces the callout to set its content container width while openning based on the available space and actual content."
Description = "Forces the callout to set its content container width while opening based on the available space and actual content."
},
new()
{
Expand Down
Loading