Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require internet connection for worker if only local subscriptions are used #388

Open
ArnyminerZ opened this issue Aug 14, 2024 · 0 comments · May be fixed by #389
Open

Do not require internet connection for worker if only local subscriptions are used #388

ArnyminerZ opened this issue Aug 14, 2024 · 0 comments · May be fixed by #389
Labels
enhancement New feature or request

Comments

@ArnyminerZ
Copy link
Member

Right now we always require internet connection, regardless of the subscriptions created

icsx5/app/src/main/java/at/bitfire/icsdroid/SyncWorker.kt

Lines 58 to 62 in 012c3b3

request.setConstraints(
Constraints.Builder()
.setRequiredNetworkType(NetworkType.CONNECTED)
.build()
)

We should only require it if network subscriptions are set. See #385
@ArnyminerZ ArnyminerZ added the enhancement New feature or request label Aug 14, 2024
@ArnyminerZ ArnyminerZ linked a pull request Aug 14, 2024 that will close this issue
Do not require internet connection for worker if only local subscriptions are used #389
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not require internet connection for worker if only local subscriptions are used bitfireAT/icsx5
1 participant
@ArnyminerZ