Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proguard breaks ical4j #384

Open
sunkup opened this issue Aug 9, 2024 · 3 comments
Open

Proguard breaks ical4j #384

sunkup opened this issue Aug 9, 2024 · 3 comments
Labels
dependent Depends on other issues/PRs

Comments

@sunkup
Copy link
Member

sunkup commented Aug 9, 2024

This issue is for tracking the changes made in #383 which we might be able to undo again.

There are unused (commented out) imports in ical4j which required us to add some proguard rules. We could report it or submit a PR that deletes these comment lines and undo #383

Originally posted by @rfc2822 in #383 (comment)

Depends on ical4j/ical4j#717

Copy link

github-actions bot commented Aug 9, 2024

This PR/issue depends on:

@github-actions github-actions bot added the dependent Depends on other issues/PRs label Aug 9, 2024
@ArnyminerZ
Copy link
Member

I've posted it on ical4j/ical4j#717, feel free to improve it if necessary. I don't know how to explain it better 😅

@sunkup
Copy link
Member Author

sunkup commented Aug 12, 2024

I've posted it on ical4j/ical4j#717, feel free to improve it if necessary. I don't know how to explain it better 😅

Nahr, sounds good. Thanks for creating it!

@sunkup sunkup changed the title PR or report for unused imports Proguard breaks ical4j Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependent Depends on other issues/PRs
Projects
None yet
Development

No branches or pull requests

2 participants