Skip to content
This repository was archived by the owner on Jun 9, 2025. It is now read-only.

Remove recurrence rules in exceptions of recurring events#138

Merged
rfc2822 merged 3 commits intomainfrom
135-ignore-recurrence-information-in-exceptions-of-recurring-events
Feb 21, 2024
Merged

Remove recurrence rules in exceptions of recurring events#138
rfc2822 merged 3 commits intomainfrom
135-ignore-recurrence-information-in-exceptions-of-recurring-events

Conversation

@sunkup
Copy link
Member

@sunkup sunkup commented Feb 21, 2024

No description provided.

@sunkup sunkup self-assigned this Feb 21, 2024
@sunkup sunkup linked an issue Feb 21, 2024 that may be closed by this pull request
@sunkup sunkup requested a review from rfc2822 February 21, 2024 09:17
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I have also verified that iCloud doesn't generate exceptions with RRULE in it (at least not when the event is created in the Web interface).

@rfc2822 rfc2822 merged commit 998f6b6 into main Feb 21, 2024
@rfc2822 rfc2822 deleted the 135-ignore-recurrence-information-in-exceptions-of-recurring-events branch February 21, 2024 14:47
@JorisBodin
Copy link

With version v4.3.16.1-ose and even the latest commit on master a246046f41c490195758d3da3f8740addef46aef, there's still the problem with davx5.
Screenshot_1715690266

I didn't see a potential rollback. How is that possible?

Sample event:

BEGIN:VCALENDAR
VERSION:2.0
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:Europe/Paris
X-LIC-LOCATION:Europe/Paris
BEGIN:STANDARD
TZOFFSETFROM:+0200
TZOFFSETTO:+0100
TZNAME:CET
DTSTART:20241027T010000
END:STANDARD
BEGIN:DAYLIGHT
TZOFFSETFROM:+0100
TZOFFSETTO:+0200
TZNAME:CEST
DTSTART:20240331T010000
END:DAYLIGHT
END:VTIMEZONE
BEGIN:VEVENT
DTSTAMP:20240508T130504Z
SUMMARY:Test
DESCRIPTION:
TRANSP:OPAQUE
SEQUENCE:3
LAST-MODIFIED:20240514T121847Z
DTSTART;TZID=Europe/Paris:20240508T120000
DTEND;TZID=Europe/Paris:20240508T130000
RRULE:FREQ=DAILY;INTERVAL=1
UID:47198a07-cc5e-4def-a4fe-29e161f5b702
END:VEVENT
BEGIN:VEVENT
DTSTAMP:20240508T130513Z
RECURRENCE-ID;TZID=Europe/Paris:20240510T120000
RRULE:FREQ=DAILY;INTERVAL=1
DTSTART;TZID=Europe/Paris:20240510T150000
DTEND;TZID=Europe/Paris:20240510T160000
SUMMARY:Test
DESCRIPTION:
TRANSP:OPAQUE
SEQUENCE:2
LAST-MODIFIED:20240514T121847Z
UID:47198a07-cc5e-4def-a4fe-29e161f5b702
END:VEVENT
END:VCALENDAR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore recurrence information in exceptions of recurring events

3 participants