Don't overwrite calendar/task list color with default color #971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a server doesn't provide a calendar/task list color, we assume a default green.
Currently, this default color is set as calendar color at every sync (when the "Manage calendar colors" setting is active [default]).
Purpose
It's enough to set the calendar color at sync only when the server actually sends a color. So the DAVx5 default color is not set at every sync.
So the when the server doesn't send a color, people can change the calendar color locally in their calendar app (for instance, aCalendar+), and it won't be overwritten at every sync by default.
Short description
A new condition is added to when calendar colors are updated:
Checklist