Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite calendar/task list color with default color #971

Merged

Conversation

rfc2822
Copy link
Member

@rfc2822 rfc2822 commented Aug 12, 2024

When a server doesn't provide a calendar/task list color, we assume a default green.

Currently, this default color is set as calendar color at every sync (when the "Manage calendar colors" setting is active [default]).

Purpose

It's enough to set the calendar color at sync only when the server actually sends a color. So the DAVx5 default color is not set at every sync.

So the when the server doesn't send a color, people can change the calendar color locally in their calendar app (for instance, aCalendar+), and it won't be overwritten at every sync by default.

Short description

A new condition is added to when calendar colors are updated:

  • "Manage calendar colors" must be active (like previously)
  • The color must be provided by the server (new condition)

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@rfc2822 rfc2822 linked an issue Aug 12, 2024 that may be closed by this pull request
1 task
@rfc2822 rfc2822 self-assigned this Aug 12, 2024
@rfc2822 rfc2822 added the enhancement New feature or request label Aug 12, 2024
@rfc2822 rfc2822 requested a review from sunkup August 12, 2024 12:11
@rfc2822 rfc2822 marked this pull request as ready for review August 13, 2024 08:38
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@rfc2822 rfc2822 merged commit 5d4c9c8 into main-ose Aug 14, 2024
12 checks passed
@rfc2822 rfc2822 deleted the 850-calendar-colors-dont-overwrite-when-not-set-by-server branch August 14, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar colors: Don't overwrite when not set by server
2 participants