Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix padding for show only personal #807

Merged
merged 2 commits into from
May 25, 2024

Conversation

ArnyminerZ
Copy link
Member

The PR should be in Draft state during development. As soon as it's finished, it should be marked as Ready for review and a reviewer should be chosen.

See also: Writing A Great Pull Request Description

Purpose

Fix the misaligned checkbox for the "Show only personal" checkbox in the account screen's dropdown menu.

Short description

  • Disabled LocalMinimumInteractiveComponentEnforcement for the checkbox.
  • Added more padding to the right to align with the padding of the icons.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ added the enhancement New feature or request label May 22, 2024
@ArnyminerZ ArnyminerZ self-assigned this May 22, 2024
@ArnyminerZ ArnyminerZ marked this pull request as ready for review May 22, 2024 14:00
@ArnyminerZ ArnyminerZ requested a review from sunkup May 22, 2024 14:00
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. :)

If I recall correctly Ricki wanted the indenting to stay, since it shows, that it's a setting and won't be confused as a (non-clickable) icon? Not sure though ...

I like it better without the indent and it should not interfere with UX 👍

@ArnyminerZ
Copy link
Member Author

If I recall correctly Ricki wanted the indenting to stay, since it shows, that it's a setting and won't be confused as a (non-clickable) icon? Not sure though ...

Yeah, I understand, but in any case it just shows the state, technically the whole item is clickable, so I think it's not necessary to add it, since it breaks quite a lot the "good-looking" of the app, without improving a whole lot on UX.

Let's wait to see what she has to say though.

@rfc2822 rfc2822 merged commit 71c57fc into main-ose May 25, 2024
7 checks passed
@rfc2822 rfc2822 deleted the fix-padding-for-show-only-personal branch May 25, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants