Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orange progress indicator bar #803

Merged
merged 4 commits into from
May 25, 2024

Conversation

sunkup
Copy link
Member

@sunkup sunkup commented May 21, 2024

Purpose

This is an addition/fix to the M3 rewrite. The progress bar was still green - like the account cards in the accounts overview, and so the pending state very hard to see.

The progress bar was orange before the rewrite to M3, this reverts it to the old state.

Short description

Change the progress indicator bar color to orange everywhere in the app.

  • Creates reusable ProgressBar composable with secondary theme color as default color
  • Replaces the usages of LinearProgressIndicator with ProgressBar.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@sunkup sunkup added the enhancement New feature or request label May 21, 2024
@sunkup sunkup self-assigned this May 21, 2024
@sunkup sunkup added refactoring Internal improvement of existing functions and removed enhancement New feature or request labels May 21, 2024
@sunkup sunkup force-pushed the change-color-of-progress-indicator-bar-to-orange branch from 1ffd024 to 586384a Compare May 21, 2024 12:32
@sunkup sunkup marked this pull request as ready for review May 21, 2024 12:33
@sunkup sunkup requested a review from rfc2822 May 21, 2024 12:33
@sunkup sunkup requested a review from ArnyminerZ May 22, 2024 10:24
Copy link
Member

@ArnyminerZ ArnyminerZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rfc2822 rfc2822 merged commit c493fbd into main-ose May 25, 2024
6 checks passed
@rfc2822 rfc2822 deleted the change-color-of-progress-indicator-bar-to-orange branch May 25, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants