Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite AppSettingsActivity to M3 #792

Merged
merged 9 commits into from
May 16, 2024

Conversation

sunkup
Copy link
Member

@sunkup sunkup commented May 15, 2024

Purpose

More of the UI is becoming M3 ✨

Short description

  • Extract composable
  • Extract model
  • Switch to M3

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@sunkup sunkup self-assigned this May 15, 2024
@sunkup sunkup added the refactoring Internal improvement of existing functions label May 16, 2024
@sunkup sunkup requested a review from rfc2822 May 16, 2024 09:18
@sunkup sunkup marked this pull request as ready for review May 16, 2024 09:18
@rfc2822 rfc2822 force-pushed the rewrite-appsettingsactivity-to-m3 branch from 91e8e93 to f42adc3 Compare May 16, 2024 09:47
@rfc2822 rfc2822 merged commit 6f02669 into main-ose May 16, 2024
7 checks passed
@rfc2822 rfc2822 deleted the rewrite-appsettingsactivity-to-m3 branch May 16, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants