Fix login detail pages loosing user changes on rotation / re-creation (closes #775) #778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Previously view models of the login details compose screens were initialized using
LaunchedEffect
, which hadLoginDetails screens loose user made changes on screen rotation/re-compose. This is because the
LaunchedEffect
was called on every re-composition, even when called with a constant likeLaunchedEffect(true)
.Injecting the view models with hilt allows to initialize the model directly when created by the hilt factory, thus circumventing the problem.
Short description
initialLoginInfo
along.See also:
https://developer.android.com/develop/ui/compose/libraries#hilt
https://developer.android.com/develop/ui/compose/libraries#viewmodel
Checklist