Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched CalDAV and CardDAV tab positions #769

Merged
merged 1 commit into from
May 2, 2024

Conversation

ArnyminerZ
Copy link
Member

The PR should be in Draft state during development. As soon as it's finished, it should be marked as Ready for review and a reviewer should be chosen.

See also: Writing A Great Pull Request Description

Purpose

Full discussion on #766.

TLDR; CalDAV tab is accessed more often than CardDAV, so it's more logical to have it first.

Short description

Switched the positions of the CalDAV and CardDAV tabs.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ linked an issue Apr 30, 2024 that may be closed by this pull request
@ArnyminerZ ArnyminerZ marked this pull request as ready for review April 30, 2024 14:12
@ArnyminerZ ArnyminerZ requested a review from rfc2822 April 30, 2024 14:12
@ArnyminerZ ArnyminerZ self-assigned this Apr 30, 2024
@ArnyminerZ ArnyminerZ added the refactoring Internal improvement of existing functions label Apr 30, 2024
@rfc2822 rfc2822 merged commit e40fa6e into main-ose May 2, 2024
7 checks passed
@rfc2822 rfc2822 deleted the 766-switch-caldavcarddav-tab branch May 2, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch CalDAV/CardDAV tab
2 participants