-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add M3 theme and apply to AboutActivity #731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else looks good 😉
Could you make a build/screenshots with the "inverse" colors I provided? Basically the above looks correct, however not totally appealing, since I always miss the ability to use our very own colors. The colors are always adapted for contrast and readability, which is useful of course but it just not pleases me :P |
Agree with you on this one. I really don't like the purple/brown-ish hue of the background ... It was similar with ICSx5 where I ended up declaring the background to be pure white - which still goes well with the other generated color nuances. |
See #691
AppTheme
toM2Theme
AppTheme
LiveData
by Compose state inOpenSourceLicenseInfoProvider.Model
@ArnyminerZ @devvv4ever @sunkup What do you think? We could gradually rewrite the activities to M3 (again one after each other with an issue/PR per activity, I'll create the issues).