Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add M3 theme and apply to AboutActivity #731

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Add M3 theme and apply to AboutActivity #731

merged 6 commits into from
Apr 19, 2024

Conversation

rfc2822
Copy link
Member

@rfc2822 rfc2822 commented Apr 15, 2024

See #691

  • rename M2 AppTheme to M2Theme
  • create new M3 theme (still subject to adaptions of colors etc.) as AppTheme
  • apply M3 theme to AboutActivity
  • replace LiveData by Compose state in OpenSourceLicenseInfoProvider.Model
  • make links in GPL text clickable

@ArnyminerZ @devvv4ever @sunkup What do you think? We could gradually rewrite the activities to M3 (again one after each other with an issue/PR per activity, I'll create the issues).

grafik
grafik
grafik

@rfc2822 rfc2822 self-assigned this Apr 15, 2024
@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Apr 15, 2024
@rfc2822 rfc2822 marked this pull request as ready for review April 15, 2024 11:56
@rfc2822 rfc2822 mentioned this pull request Apr 15, 2024
12 tasks
gradle/libs.versions.toml Outdated Show resolved Hide resolved
@rfc2822 rfc2822 requested a review from ArnyminerZ April 15, 2024 17:23
Copy link
Member

@ArnyminerZ ArnyminerZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good 😉

@devvv4ever
Copy link
Member

Could you make a build/screenshots with the "inverse" colors I provided?

Basically the above looks correct, however not totally appealing, since I always miss the ability to use our very own colors. The colors are always adapted for contrast and readability, which is useful of course but it just not pleases me :P

@sunkup
Copy link
Member

sunkup commented Apr 17, 2024

Basically the above looks correct, however not totally appealing, since I always miss the ability to use our very own colors. The colors are always adapted for contrast and readability, which is useful of course but it just not pleases me :P

Agree with you on this one. I really don't like the purple/brown-ish hue of the background ...

It was similar with ICSx5 where I ended up declaring the background to be pure white - which still goes well with the other generated color nuances.

@rfc2822 rfc2822 merged commit 34b88c3 into main-ose Apr 19, 2024
7 checks passed
@rfc2822 rfc2822 deleted the m3-theme-about branch April 19, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants