Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More correct usage of expedited workers #566

Merged
merged 11 commits into from
Feb 22, 2024
Merged

More correct usage of expedited workers #566

merged 11 commits into from
Feb 22, 2024

Conversation

rfc2822
Copy link
Member

@rfc2822 rfc2822 commented Feb 13, 2024 •
edited
Loading

Maybe related to https://github.com/bitfireAT/davx5/issues/520

@rfc2822 rfc2822 changed the title Add foreground notification type to potentially expedited workers Make sync worker long-running (not only expedited) Feb 13, 2024
@rfc2822 rfc2822 force-pushed the long-running-workers-need-a-foreground-service-type branch from faf0648 to 6ce1715 Compare February 13, 2024 11:13
@rfc2822 rfc2822 linked an issue Feb 13, 2024 that may be closed by this pull request
Long-running workers need a foreground service type #565
Closed
@rfc2822 rfc2822 force-pushed the long-running-workers-need-a-foreground-service-type branch from a3130c1 to cc9b829 Compare February 13, 2024 13:26
@rfc2822 rfc2822 marked this pull request as ready for review February 13, 2024 13:44
@rfc2822 rfc2822 requested a review from sunkup February 13, 2024 13:48
@rfc2822 rfc2822 changed the title Make sync worker long-running (not only expedited) More correct usage of expedited and long-running workers Feb 13, 2024
@rfc2822 rfc2822 marked this pull request as draft February 13, 2024 17:07
@rfc2822 rfc2822 removed the request for review from sunkup February 13, 2024 17:07
@rfc2822 rfc2822 changed the title More correct usage of expedited and long-running workers More correct usage of expedited workers Feb 14, 2024
@rfc2822 rfc2822 requested a review from sunkup February 15, 2024 07:45
@rfc2822 rfc2822 self-assigned this Feb 15, 2024
@rfc2822 rfc2822 marked this pull request as ready for review February 15, 2024 07:45
@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Feb 15, 2024
@rfc2822 rfc2822 requested review from sunkup and removed request for sunkup February 21, 2024 10:38
@rfc2822

This comment was marked as outdated.

Sign in to view
@rfc2822 rfc2822 marked this pull request as draft February 21, 2024 14:33
@rfc2822 rfc2822 removed the request for review from sunkup February 21, 2024 14:33
@rfc2822 rfc2822 force-pushed the long-running-workers-need-a-foreground-service-type branch from 90feb48 to 04ed557 Compare February 21, 2024 14:40
@rfc2822 rfc2822 marked this pull request as ready for review February 21, 2024 14:41
@rfc2822 rfc2822 requested a review from sunkup February 21, 2024 14:41
@sunkup sunkup mentioned this pull request Feb 22, 2024
Closed
sunkup
sunkup approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@sunkup sunkup left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope this improves things 👍

btw. I also found and filed #592 , which might be relevant :)

@rfc2822 rfc2822 merged commit cae1ed5 into dev-ose Feb 22, 2024
7 checks passed
@rfc2822 rfc2822 deleted the long-running-workers-need-a-foreground-service-type branch February 22, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunkup sunkup sunkup approved these changes

Assignees

@rfc2822 rfc2822

Labels
refactoring Internal improvement of existing functions
Projects
DAVx⁵ Releases
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Long-running workers need a foreground service type
2 participants
@rfc2822 @sunkup