Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gradle version catalog #564

Merged
merged 8 commits into from
Feb 15, 2024
Merged

Use gradle version catalog #564

merged 8 commits into from
Feb 15, 2024

Conversation

ArnyminerZ
Copy link
Member

No description provided.

@ArnyminerZ
Using version catalog
5510f3d 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ requested a review from rfc2822 February 12, 2024 19:20
@ArnyminerZ ArnyminerZ self-assigned this Feb 12, 2024
@ArnyminerZ ArnyminerZ linked an issue Feb 12, 2024 that may be closed by this pull request
Use version catalog #484
Closed
@ArnyminerZ ArnyminerZ removed the request for review from rfc2822 February 12, 2024 19:21
@ArnyminerZ
Fixed library names
ee06720 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ requested a review from rfc2822 February 12, 2024 19:28
@ArnyminerZ ArnyminerZ marked this pull request as ready for review February 12, 2024 19:28
rfc2822
rfc2822 reviewed Feb 13, 2024
View reviewed changes
gradle/libs.versions.toml Outdated Show resolved Hide resolved
rfc2822
rfc2822 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@rfc2822 rfc2822 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good. I have reordered things minimally, and added some other changes, notably to use Compose BOM again. Was there a specific reason for dropping it?

Guess I see it… (strange, in Android Studio it worked)

Compose BOM working again

@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Feb 15, 2024
@rfc2822 rfc2822 changed the title Use version catalog Use gradle version catalog Feb 15, 2024
@rfc2822 rfc2822 merged commit 8ac95e0 into dev-ose Feb 15, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 484-use-version-catalog branch February 15, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfc2822 rfc2822 rfc2822 approved these changes

Assignees

@ArnyminerZ ArnyminerZ

Labels
refactoring Internal improvement of existing functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use version catalog
2 participants
@ArnyminerZ @rfc2822