Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-creation / rotation of LoginDetails page looses user changes #775

Closed
sunkup opened this issue May 2, 2024 · 0 comments · Fixed by #778
Closed

Re-creation / rotation of LoginDetails page looses user changes #775

sunkup opened this issue May 2, 2024 · 0 comments · Fixed by #778
Assignees
@sunkup
Labels
bug Something isn't working

Comments

@sunkup
Copy link
Member

sunkup commented May 2, 2024 •
edited
Loading

Might be because LoginScreen is dropped and complete re-compose happens when the screen is rotated, and it calls:

LaunchedEffect(initialLoginInfo) {
    model.initialize(initialLoginInfo)
}

which initializes the login data from initialLoginInfo. However the initialLoginInfo should probably only be taken into account at the very first time, ideally from the Activity (that provides the initial login info).

Originally posted by @rfc2822 in #772 (review)
@sunkup sunkup added the bug Something isn't working label May 2, 2024
@sunkup sunkup linked a pull request May 3, 2024 that will close this issue
Fix login detail pages loosing user changes on rotation / re-creation (closes #775) #778
Merged
4 tasks
@sunkup sunkup moved this from Todo to In Progress in DAVx⁵ Releases May 3, 2024
@sunkup sunkup moved this from In Progress to In Review in DAVx⁵ Releases May 6, 2024
rfc2822 pushed a commit that referenced this issue May 7, 2024
@sunkup
Fix login detail pages loosing user changes on rotation / re-creation (…
ad24dd5 
…closes #775) (#778)

Inject view models in composables using hilt
@github-project-automation github-project-automation bot moved this from In Review to Done in DAVx⁵ Releases May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunkup sunkup

Labels
bug Something isn't working
Projects
DAVx⁵ Releases
Archived in project
Milestone
No milestone
1 participant
@sunkup