Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bitdynamics-ab/canton-devkit
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.17.2
Choose a base ref
...
head repository: bitdynamics-ab/canton-devkit
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.17.3
Choose a head ref
  • 1 commit
  • 13 files changed
  • 1 contributor

Commits on Aug 15, 2026

  1. feat(localnet): confirm before removing a running instance (#315)

    A running instance used to make `localnet remove` fail outright with a
    --force hint, turning the common case — throw this instance away — into
    a two-command chore and reporting "Removed 0 of 1 instance(s)" for
    exactly what the user intended.
    
    On an interactive terminal remove now prints what will be destroyed and
    asks "Stop and remove <name>? [y/N]:"; answering y tears the instance
    down and removes it in one step, anything else leaves it untouched with
    a non-zero exit. --force skips the prompt and is required when stdin
    cannot answer one.
    
    The TTY guard goes through a new term.CanPrompt: a plain
    os.ModeCharDevice check misclassifies /dev/null as a terminal (it is a
    character device), which made `remove < /dev/null` print the prompt,
    read EOF, and silently report the instance as kept — the destructive
    command appeared to refuse while never asking. CanPrompt uses isatty on
    real files, so pipes, redirects, and /dev/null all fail fast with a
    --force hint; non-file readers stay promptable for tests.
    
    Web UI parity: DELETE /api/instances/{name}?force=true is the wire form
    of the confirmation — the handler returns 409 INSTANCE_RUNNING only
    without it, and the frontend's remove dialog sends it only after the
    user accepts, with running-specific copy and a Remove button now
    available on running instances. --dry-run never prompts and reports
    that confirmation would be requested first.
    zheli authored Aug 15, 2026
    Configuration menu
    Copy the full SHA
    4c83f4f View commit details
    Browse the repository at this point in the history
Loading