[EX-111] Remove unused configuration #100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new boolean field - "active" to system prompts. The field has a unique index on it, so that there can always only be one active system prompt. The migration also migrates the currently activated prompt from the runtime configuration to be set to "active". If the configuration isn't present any more, a random prompt from the DB will be set to as the active one.
The test is only verifying whether the unique index is present and working as expected.
The test was not really testing anything: it was not checking whether the system prompt was actually gone from the page. In fact, it checked the opposite… The problem was, that there are already two prompts in the database. And as they are all from the same factory, they share the same prompt…
Activating a system prompt deactivates the currently active one.
We'll keep the configuration for a smoother migration path for now.
Also: update migration to only activate an existing system prompt of there is no active one yet.
I felt like this makes the tests harder to reason about.
agatheblues
reviewed
Oct 1, 2025
| llm_config: %{ | ||
| # Random IDs that is used in the tests! | ||
| model_config_provider_id: "9a21bfd3-cb0a-433c-a9b3-826143782c81", | ||
| system_prompt_id: "96123e4b-7d0a-4e14-82d4-63d68562e8f1", |
There was a problem hiding this comment.
I think we can also get rid of the use of test_system_prompt_id() in the tests then, right? ✂️
NOTE: also remove the `CURRENT_LLM_SYSTEM_PROMPT_ID` environment variable from the production and staging systems.
klappradla
force-pushed
the
story/ex-111-follow-up
branch
from
773edf3 to
83f9da5
Compare
Base automatically changed from
story/ex-111-activate-a-system-prompt
to
main
October 13, 2025 08:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: also remove the
CURRENT_LLM_SYSTEM_PROMPT_IDenvironment variablefrom the production and staging systems.