Skip to content

Conversation

@andreasknoepfle
Copy link
Member

…u-height-100vh in sidebar

#96

…u-height-100vh in sidebar

#96
@andreasknoepfle andreasknoepfle force-pushed the feature/96-use-u-height-stretch-instead-of-u-height-100vh-in-sidebar branch from 6000148 to 8a07290 Compare December 14, 2022 10:08
"cmd mkdir -p priv/static/assets",
"cmd cp -R assets/node_modules/bitstyles/assets/* priv/static/assets"
"cmd cp -R assets/node_modules/bitstyles/assets/* priv/static/assets",
"cmd cp -R ../assets/logo.svg priv/static/assets/images/"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

side thing, since the demo app image is broken

Copy link
Member

@planktonic planktonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve left suggestions with the current classes we use on frontend apps. It might mean that we don't need the autoprefixer, as it contains a fallback already — let me check it locally this afternoon though

@planktonic
Copy link
Member

I just pushed a commit with updated classnames — it works for me in safari, firefox, and chrome, with or without autoprefixer (the extra niceness of stretch is not there when the browser doesn’t support it of course, but then it falls back to height:100vh).

I think the autoprefixer flag is unnecessary in this case, wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants