Add auto-detection for color LED deck variants in examples #578
+60
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for detecting and using both bottom-facing and top-facing color LED decks on Crazyflie drones. The code now dynamically detects which deck type is connected and automatically configures the appropriate parameters.
- Added deck detection logic that checks for both
bcColorLedBotandbcColorLedTopdeck types - Refactored hardcoded parameter names to use a dynamic
deck_paramsdictionary - Updated all parameter references to use the detected deck's parameter names
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| examples/color_led_deck/color_led_set.py | Added deck detection logic and replaced hardcoded parameter names with dynamic deck_params dictionary for setting a single LED color |
| examples/color_led_deck/color_led_cycle.py | Added deck detection logic and replaced hardcoded parameter names with dynamic deck_params dictionary for cycling through colors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Color LED examples now detect which deck variant is present (bottom or top-facing) and use the first one found. This keeps examples simple while supporting both colorLedBot and colorLedTop parameter groups.
gemenerik
force-pushed
the
rik/clr_led_variants
branch
from
9d1801f to
017633b
Compare
ArisMorgens
approved these changes
Nov 25, 2025
Member
ArisMorgens
left a comment
ArisMorgens
left a comment
There was a problem hiding this comment.
Looks good! I tested it with the latest crazyflie-firmware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Color LED examples now detect which deck variant is present (bottom or top-facing) and use the first one found. This keeps examples simple while supporting both colorLedBot and colorLedTop parameter groups.
Requires bitcraze/crazyflie-firmware#1553