Newsletter-81:Translate into Japanese #345
Conversation
jnewbery
added
localization-japanese
There was a problem hiding this comment.
ACK.
Tested links and build and looks good.
One small optimization could be made for one of the links but requires a change to the auto anchoring. I dont think this should hold up merge. @jnewbery thoughts?
| [dlcspecs]: https://github.com/discreetlogcontracts/dlcspecs/ | ||
| [scriptless scripts examples]: https://github.com/ElementsProject/scriptless-scripts | ||
| [whatsat]: https://github.com/joostjager/whatsat | ||
| [news72 sphinx]: /en/newsletters/2019/11/13/#possible-privacy-leak-in-the-ln-onion-format |
There was a problem hiding this comment.
This link has a ja version at https://bitcoinops.org/ja/newsletters/2019/11/13/, but the #/anchor link isnt being populated.
There was a problem hiding this comment.
@Ichiro0219 rebase looks good, can you add a change for this link to go to
/ja/newsletters/2019/11/13/#ln-1
Since we fixed the anchor for that page and we have the Japanese version? Thanks!
There was a problem hiding this comment.
@Ichiro0219 can you make this link change above? That should be it before merging.
|
@Ichiro0219 can you rebase on master, which has the recently merged #349 Also, if you review #349 you will see how the anchor links will work moving forward. Especially the part around putting in the comment tag if there are duplicate anchors which you might run into. |
Ichiro0219
force-pushed
the
newsletter-81
branch
from
f8f710e to
aa20fbe
Compare
|
@bitschmidty |
Ichiro0219
force-pushed
the
newsletter-81
branch
from
7977da2 to
3842290
Compare
|
@Ichiro0219 looks like your force push caused an error with github closing this PR. Can you open a new one? Sorry for this hassle. |
No description provided.