Change DatabaseFactory::build descriptor input to use reference.

Author: evanlinjin

src/database/any.rs

@@ -445,7 +445,7 @@ impl DatabaseFactory for AnyDatabaseFactory {
 
     fn build(
         &self,
-        descriptor: ExtendedDescriptor,
+        descriptor: &ExtendedDescriptor,
         network: Network,
         secp: &SecpCtx,
     ) -> Result<Self::Inner, Error> {

src/database/keyvalue.rs

@@ -411,11 +411,11 @@ impl DatabaseFactory for sled::Db {
 
     fn build(
         &self,
-        descriptor: crate::descriptor::ExtendedDescriptor,
+        descriptor: &crate::descriptor::ExtendedDescriptor,
         network: bitcoin::Network,
         secp: &crate::wallet::utils::SecpCtx,
     ) -> Result<Self::Inner, Error> {
-        let name = wallet_name_from_descriptor(descriptor, None, network, secp)?;
+        let name = wallet_name_from_descriptor(descriptor.clone(), None, network, secp)?;
         self.open_tree(&name).map_err(Error::Sled)
     }
 }

src/database/memory.rs

@@ -486,7 +486,7 @@ impl DatabaseFactory for MemoryDatabaseFactory {
 
     fn build(
         &self,
-        _descriptor: crate::descriptor::ExtendedDescriptor,
+        _descriptor: &crate::descriptor::ExtendedDescriptor,
         _network: bitcoin::Network,
         _secp: &crate::wallet::utils::SecpCtx,
     ) -> Result<Self::Inner, Error> {

src/database/mod.rs

@@ -223,7 +223,7 @@ pub trait DatabaseFactory: Sized {
     /// Builds the defined [`DatabaseFactory::Inner`] type.
     fn build(
         &self,
-        descriptor: ExtendedDescriptor,
+        descriptor: &ExtendedDescriptor,
         network: Network,
         secp: &SecpCtx,
     ) -> Result<Self::Inner, Error>;
@@ -479,7 +479,7 @@ pub mod test {
 
         let mut acc_index = 0_usize;
         let mut database = || {
-            let db = fac.build(descriptor(acc_index), network, &secp).unwrap();
+            let db = fac.build(&descriptor(acc_index), network, &secp).unwrap();
             acc_index += 1;
             db
         };

src/database/sqlite.rs

@@ -990,14 +990,14 @@ impl<P: AsRef<Path>> DatabaseFactory for SqliteDatabaseFactory<P> {
 
     fn build(
         &self,
-        descriptor: crate::descriptor::ExtendedDescriptor,
+        descriptor: &crate::descriptor::ExtendedDescriptor,
         network: bitcoin::Network,
         secp: &crate::wallet::utils::SecpCtx,
     ) -> Result<Self::Inner, Error> {
         // ensure dir exists
         std::fs::create_dir_all(&self.dir).map_err(|e| Error::Generic(e.to_string()))?;
 
-        let name = wallet_name_from_descriptor(descriptor, None, network, secp)?;
+        let name = wallet_name_from_descriptor(descriptor.clone(), None, network, secp)?;
         let ext = self.ext.trim_start_matches('.');
 
         let mut path = std::path::PathBuf::new();