-
Notifications
You must be signed in to change notification settings - Fork 11
Bump bdk version to 0.24.0 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This still has some bugs to fix and can't be merged until after bdk 0.24.0 is released. |
|
Looks like the only failing test is just the error message that slightly changed, this should be able to move forward |
|
I had to fix a couple things to get tests to pass:
|
606fa3c to
b7ccd36
Compare
b7ccd36 to
a944bb2
Compare
ulrichard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I also tested with our application, where this is used. All good. Thanks for maintaining this.
|
I'll make the release now and then we'll get the updated |
Description
Update BDK to the latest version, 0.24.0.
Notes to the reviewers
I also had to add base64 as a new dev dependency because it's not exported by bdk.