Skip to content

Conversation

@notmandatory
Copy link
Member

Description

Update BDK to the latest version, 0.24.0.

Notes to the reviewers

I also had to add base64 as a new dev dependency because it's not exported by bdk.

@notmandatory notmandatory self-assigned this Nov 2, 2022
@notmandatory
Copy link
Member Author

This still has some bugs to fix and can't be merged until after bdk 0.24.0 is released.

@notmandatory notmandatory marked this pull request as draft November 2, 2022 20:29
@notmandatory notmandatory mentioned this pull request Nov 2, 2022
24 tasks
@benthecarman
Copy link

Looks like the only failing test is just the error message that slightly changed, this should be able to move forward

@notmandatory
Copy link
Member Author

I had to fix a couple things to get tests to pass:

  • updated to new Miniscript error string
  • according to bitcoin-cli and bip173.org the new PSBT data looks like it added a value for bip32_derivs, otherwise PSBTs are the same, so updated test with new PSBT.
diff psbt-left.txt psbt-right.txt 
73,80c73
<       },
<       "bip32_derivs": [
<         {
<           "pubkey": "032b0558078bec38694a84933d659303e2575dae7e91685911454115bfd64487e3",
<           "master_fingerprint": "ece52657",
<           "path": "m"
<         }
<       ]
---
>       }

@notmandatory notmandatory marked this pull request as ready for review November 4, 2022 21:03
@notmandatory notmandatory marked this pull request as draft November 4, 2022 21:04
@notmandatory notmandatory marked this pull request as ready for review November 6, 2022 01:06
@notmandatory notmandatory requested review from ulrichard and removed request for rajarshimaitra November 7, 2022 20:48
Copy link
Collaborator

@ulrichard ulrichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I also tested with our application, where this is used. All good. Thanks for maintaining this.

@ulrichard ulrichard merged commit df5005c into bitcoindevkit:main Nov 11, 2022
@notmandatory
Copy link
Member Author

I'll make the release now and then we'll get the updatedbdk-cli released too. Thanks for testing it out with your app.

@notmandatory notmandatory removed this from BDK-CLI May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants