Bump bdk version to 0.24.0 #129
Conversation
|
This is ready to review, but can't be merged until after |
notmandatory
force-pushed
the
update_bdk_024
branch
6 times, most recently
from
2d5e33d to
9e55d6f
Compare
|
This needs to be updated once bitcoindevkit/bdk-reserves#16 is merged and released. |
notmandatory
force-pushed
the
update_bdk_024
branch
from
9e55d6f to
dbcdbc4
Compare
notmandatory
force-pushed
the
update_bdk_024
branch
from
dbcdbc4 to
b21fb4b
Compare
rajarshimaitra
left a comment
rajarshimaitra
left a comment
There was a problem hiding this comment.
Sorry took me some time to get back to this..
tACK b667738
Probably I am missing the context of it, but I just have one question..
| zeroize = "<1.4.0" | ||
| dirs-next = "2.0" | ||
| env_logger = "0.7" | ||
| base64 = "^0.13" |
There was a problem hiding this comment.
Why separately base64 when bitcoin reexports it? I am guessing some version conflicts in the process of upgrade?
But this makes us have two separate base64 dependencies.
[[package]]
name = "base64"
version = "0.13.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "9e1b586273c5702936fe7b7d6896644d8be71e6314cfe09d3167c95f712589e8"
[[package]]
name = "base64-compat"
version = "1.0.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "5a8d4d2746f89841e49230dd26917df1876050f95abafafbe34f47cb534b88d7"
dependencies = [
"byteorder",
]
I don't know in details the diffs between these two crates, but is this intended?
There was a problem hiding this comment.
The problem I ran into is that the latest rust-bitcoin doesn't re-export the base64 package. I copied the base64 version from the rust-bitcoin Cargo.toml:
[dependencies.base64]
version = "0.13.0"
optional = true@afilini has a PR that was merged to fix this, but it looks like it's just not released yet. rust-bitcoin/rust-bitcoin#1342
There was a problem hiding this comment.
Awesome.. It can then be resolved later once the PR is merged.. Opening a ticket to keep us reminded..
2 participants
Description
Update BDK to the latest version, 0.24.0.
Notes to the reviewers
I also had to add
base64as a new dependency because it's not exported bybdk.There's probably a more elegant way to fix the
wasm.rscompiler function for descriptor.translate_pk, and I don'tknow how create a unit test it since it only runs on wasm32. But at least it builds so I think that's close enough for now.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing