p2p: detect addnode cjdns peers in GetAddedNodeInfo()

[jonatack]

Addnode peers connected to us via the cjdns network are currently not detected by CConnman::GetAddedNodeInfo(), i.e. fConnected is always false. This causes the following issues:

• RPC getaddednodeinfo incorrectly shows them as not connected

• CConnman::ThreadOpenAddedConnections() continually retries to connect them

Fix the issue and add a unit regression test. Extracted from #28248. Suggest running the test with:

./src/test/test_bitcoin -t net_peer_connection_tests -l test_suite

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	mzumsande, brunoerg, pinheadmz

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

[jonatack]

This straightforward fix (5f53e6c) was previously ACKed by @vasild (#28248 (review) and Concept ACKed by @brunoerg (#28248 (comment)) with a request to add test coverage, which I've added here.

(Thank you @luke-jr for updating bitcoin knots.)

@vasild @brunoerg mind having a look (thanks!)

[mzumsande]

utACK d0b0474

[brunoerg]

crACK d0b0474

[pinheadmz]

ACK d0b0474

Built and tested on arm/macOS. It's a simple fix to recognize CJDNS addresses in GetAddedNodeInfo(). Otherwise CService::IsValid() will fail because the CJDNS prefix is in a reserved range. Confirmed the test fails on master and passes with the branch.

Show Signature

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

ACK d0b047494c28381942c09d0cca45baa323bfcffc
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAmZE+NUACgkQ5+KYS2KJ
yTqRLA/+PTzgnOENcfPRDjRTqOrwzxdHPDW8xHu+m0VcLZO0Uv4HwIW8ArZk7DJB
va3z0Y4gIWYvpLwLR+pUlSFqsLKmgsi+gYSVkGK3sGBAGvTH8ibNfKWKdSxzQaAs
PHkutSbYFchel2aO7g/cVzNsD4IfbWvGMmxj2f4kNX0RcWG49IHi3xlMh7ppqn8x
NjS+Xl8kzCgz8oYPQVh7KMKOLEeu+FcoaKRrWhgkhWn6A+CNRbyxwcZYXWrx1oY5
uK+tgnnbvRoYaTg7BTluFfitOqUGPnsMWw52a+vPbtq0lMbtLGby6nPrDwlr1jCn
HPMxz4klxHoqYXJa138Exywyck0Ziu4eqeq/jzi1vQO4KBm6MaiHWrBpfjr/i5uS
Vc/eWPzlTHXktT4MDOb2Mtgfrcu35zQlaU4HMCkLnJGhtFDRhiab99kGHbq+h/LF
kVrePOsVStPNg0s5UwxQIYdEBw4UXePCCPRwe9xxi7UoGGq8mmX6W7AFFn90bepQ
n6a579L6y9olxEr0+Xh863B0esen6wh7znCIm8YJfBHoNJZmOe3tTiWNn0+HQF9e
lqat+HDHY6H24jWSSlqpIvYtHMMe/FeP/5rNldWIdLxIAl3Nc3RPnfmYOTnnZv7F
djr3j+Tk1sIl7hKNqYg9eFcoIzRyLqecJOPDxVrK3eCPVdM12OA=
=u4ll
-----END PGP SIGNATURE-----

pinheadmz's public key is on keybase

[pinheadmz]

Confirmed this branch fixes the issue in production on mainnet as well:

$ bccli getaddednodeinfo
[
  {
    "addednode": "fc32:17ea:e415:c3bf:9808:149d:b5a2:c9aa",
    "connected": false,
    "addresses": [
    ]
  },
  {
    "addednode": "fcc7:be49:ccd1:dc91:3125:f0da:457d:8ce",
    "connected": true,
    "addresses": [
      {
        "address": "[fcc7:be49:ccd1:dc91:3125:f0da:457d:8ce]:8333",
        "connected": "outbound"
      }
    ]
  }
]

[fanquake]

Backported to 27.x in #30092.