Skip to content

guix: use GCC tool wrappers #27345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

fanquake
Copy link
Member

This way, correct --plugin arguments are passed through.

This is a prerequisite for LTO (see #25391). Split out, to try move things along, as this change is isolated, and should be straight-forward.

This way, correct `--plugin` argument are passed through.

This is a prerequisite for LTO (see bitcoin#25391).
@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 27, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK TheCharlatan, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@hebasto
Copy link
Member

hebasto commented Mar 27, 2023

Concept ACK.

Copy link
Contributor

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4133c81

Split out, to try move things along, as this change is isolated, and should be straight-forward.

Is there a reason for the LTO PR being bogged down?

find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
df90584fe5c1c68ec6a547ba04b81b66fae61035d5d4b586bc2c70f19176bc62  guix-build-4133c8104f52/output/aarch64-linux-gnu/SHA256SUMS.part
ba5553f64f73d84850ffe4e2c1712bd803c6e6f13b9f57cbc82eecab8e9e82c1  guix-build-4133c8104f52/output/aarch64-linux-gnu/bitcoin-4133c8104f52-aarch64-linux-gnu-debug.tar.gz
316e07c7baae2ff35e929c25d472ef0b66077b275c2c55f4b24acdd015947e80  guix-build-4133c8104f52/output/aarch64-linux-gnu/bitcoin-4133c8104f52-aarch64-linux-gnu.tar.gz
5ab974cb994b99e3091ad7134d819c9b21d4b42ed0444ba480c380658645781a  guix-build-4133c8104f52/output/arm-linux-gnueabihf/SHA256SUMS.part
aefd9b75d1c7e4f0c52b3dabae0de9ffd0d24080b0bdec62fa76ccefed22f4b0  guix-build-4133c8104f52/output/arm-linux-gnueabihf/bitcoin-4133c8104f52-arm-linux-gnueabihf-debug.tar.gz
97ed3a9d929edd833895dcfff4453bdc37483cc06ddc395441854f067332a4c8  guix-build-4133c8104f52/output/arm-linux-gnueabihf/bitcoin-4133c8104f52-arm-linux-gnueabihf.tar.gz
987e51837b189affdc8131c1ef49f90d4112cdc8170bb1852e1c4c592f33ca77  guix-build-4133c8104f52/output/arm64-apple-darwin/SHA256SUMS.part
06571934952a674481bfc725bce6ae0125ebaf31e69bbd81cc747b321c066eca  guix-build-4133c8104f52/output/arm64-apple-darwin/bitcoin-4133c8104f52-arm64-apple-darwin-unsigned.dmg
96a71f04bcedbe3cd515c0226012d2876a0c9c3397e648689b39d7bed44dad96  guix-build-4133c8104f52/output/arm64-apple-darwin/bitcoin-4133c8104f52-arm64-apple-darwin-unsigned.tar.gz
e09c39129cd5de4274bfc04c1cdace1bdfbea381d23133407256aa109e5e259c  guix-build-4133c8104f52/output/arm64-apple-darwin/bitcoin-4133c8104f52-arm64-apple-darwin.tar.gz
2bf2a112d28ce43e6324538b5588070f75a04a70049545a55a507f829035f614  guix-build-4133c8104f52/output/dist-archive/bitcoin-4133c8104f52.tar.gz
446166729306e764c4be31495cb42e3f1874a7cead37c43d353563d050d8e20d  guix-build-4133c8104f52/output/powerpc64-linux-gnu/SHA256SUMS.part
8ac44fd4e6b4b4f0d8a0a600fd02eb7a77407d911f8f8ee1e8d67a401076e16e  guix-build-4133c8104f52/output/powerpc64-linux-gnu/bitcoin-4133c8104f52-powerpc64-linux-gnu-debug.tar.gz
45a7cda2cd55a253611105e47314b8aa54ba05304a6e0ab913434b17613d96d8  guix-build-4133c8104f52/output/powerpc64-linux-gnu/bitcoin-4133c8104f52-powerpc64-linux-gnu.tar.gz
be2bb897ab2eeb5b0dc6069a568b1765d25bbbc9f8a81ff94893864050feb9e0  guix-build-4133c8104f52/output/powerpc64le-linux-gnu/SHA256SUMS.part
c8d9bbf6a19294ee97317f61a0798effb05d6b5fb016a5d585ab0f33724cd715  guix-build-4133c8104f52/output/powerpc64le-linux-gnu/bitcoin-4133c8104f52-powerpc64le-linux-gnu-debug.tar.gz
f012b8570dcb60c018b1af7be4cb0c65d09881537ff7ce890727b90d30554cce  guix-build-4133c8104f52/output/powerpc64le-linux-gnu/bitcoin-4133c8104f52-powerpc64le-linux-gnu.tar.gz
95b75d7442205a95040dc8c9002bfd9bc9f361eb2db8f9c0fa5380796fc2ce7b  guix-build-4133c8104f52/output/riscv64-linux-gnu/SHA256SUMS.part
626de2b5d5459854165063a7dc0e452f69916c5108e6f15dec01f0121ddd0652  guix-build-4133c8104f52/output/riscv64-linux-gnu/bitcoin-4133c8104f52-riscv64-linux-gnu-debug.tar.gz
0bb2d4d10e584f668722fc9c00593a3194eccec44e4c085c73e88425859e9cff  guix-build-4133c8104f52/output/riscv64-linux-gnu/bitcoin-4133c8104f52-riscv64-linux-gnu.tar.gz
c8af6dea25beeb28fdef8e04fe5fde875ce0dbae38a8c038a5a59f699ef303bc  guix-build-4133c8104f52/output/x86_64-apple-darwin/SHA256SUMS.part
10c07f6b9e3df63a4772741d4bb246f9794db92b0af8f6b4e765188a6f2b108b  guix-build-4133c8104f52/output/x86_64-apple-darwin/bitcoin-4133c8104f52-x86_64-apple-darwin-unsigned.dmg
ced541daeeb58b403c3a25df9daabe82a3e62ad85dd3a78b5d9495955cce8835  guix-build-4133c8104f52/output/x86_64-apple-darwin/bitcoin-4133c8104f52-x86_64-apple-darwin-unsigned.tar.gz
904c0cc18e24c878629a1a54664a212b008cd72a624e6be204968f2e4676a283  guix-build-4133c8104f52/output/x86_64-apple-darwin/bitcoin-4133c8104f52-x86_64-apple-darwin.tar.gz
2c90a8d1484dc2aa011645e4e3570e606d5be26408d7596e3f70b8dc25e8b055  guix-build-4133c8104f52/output/x86_64-linux-gnu/SHA256SUMS.part
6a74fdba8a848157764c44a382729b1231e8ab52750c0b00d3f54efab3cd98e5  guix-build-4133c8104f52/output/x86_64-linux-gnu/bitcoin-4133c8104f52-x86_64-linux-gnu-debug.tar.gz
b3201f583c816245e61f31efc6d95b5d065a7851844c38d67bb7fe7b4cb85d59  guix-build-4133c8104f52/output/x86_64-linux-gnu/bitcoin-4133c8104f52-x86_64-linux-gnu.tar.gz
45f87b892b49e5a191e283115375b31dc826d82c31f294a34e7d5911efc919c4  guix-build-4133c8104f52/output/x86_64-w64-mingw32/SHA256SUMS.part
3093c885bc5965a22686bcc9fb5a8add270673bbdf3592af855b1ccf14ac95ca  guix-build-4133c8104f52/output/x86_64-w64-mingw32/bitcoin-4133c8104f52-win64-debug.zip
3bd77e190aaa323c4ec75725dd42c3a54b7549d2c95674f5825e2f64b212e8d8  guix-build-4133c8104f52/output/x86_64-w64-mingw32/bitcoin-4133c8104f52-win64-setup-unsigned.exe
adf7f12a65d67941569e1f9a8016c8f18987ace9e02e4f8acadb100c29231941  guix-build-4133c8104f52/output/x86_64-w64-mingw32/bitcoin-4133c8104f52-win64-unsigned.tar.gz
8e915cfc6b4315a7698c411bfddb6956073e58526df36df95368eb4069bf47a5  guix-build-4133c8104f52/output/x86_64-w64-mingw32/bitcoin-4133c8104f52-win64.zip

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4133c81

Guix builds:

df90584fe5c1c68ec6a547ba04b81b66fae61035d5d4b586bc2c70f19176bc62  guix-build-4133c8104f52/output/aarch64-linux-gnu/SHA256SUMS.part
ba5553f64f73d84850ffe4e2c1712bd803c6e6f13b9f57cbc82eecab8e9e82c1  guix-build-4133c8104f52/output/aarch64-linux-gnu/bitcoin-4133c8104f52-aarch64-linux-gnu-debug.tar.gz
316e07c7baae2ff35e929c25d472ef0b66077b275c2c55f4b24acdd015947e80  guix-build-4133c8104f52/output/aarch64-linux-gnu/bitcoin-4133c8104f52-aarch64-linux-gnu.tar.gz
5ab974cb994b99e3091ad7134d819c9b21d4b42ed0444ba480c380658645781a  guix-build-4133c8104f52/output/arm-linux-gnueabihf/SHA256SUMS.part
aefd9b75d1c7e4f0c52b3dabae0de9ffd0d24080b0bdec62fa76ccefed22f4b0  guix-build-4133c8104f52/output/arm-linux-gnueabihf/bitcoin-4133c8104f52-arm-linux-gnueabihf-debug.tar.gz
97ed3a9d929edd833895dcfff4453bdc37483cc06ddc395441854f067332a4c8  guix-build-4133c8104f52/output/arm-linux-gnueabihf/bitcoin-4133c8104f52-arm-linux-gnueabihf.tar.gz
987e51837b189affdc8131c1ef49f90d4112cdc8170bb1852e1c4c592f33ca77  guix-build-4133c8104f52/output/arm64-apple-darwin/SHA256SUMS.part
06571934952a674481bfc725bce6ae0125ebaf31e69bbd81cc747b321c066eca  guix-build-4133c8104f52/output/arm64-apple-darwin/bitcoin-4133c8104f52-arm64-apple-darwin-unsigned.dmg
96a71f04bcedbe3cd515c0226012d2876a0c9c3397e648689b39d7bed44dad96  guix-build-4133c8104f52/output/arm64-apple-darwin/bitcoin-4133c8104f52-arm64-apple-darwin-unsigned.tar.gz
e09c39129cd5de4274bfc04c1cdace1bdfbea381d23133407256aa109e5e259c  guix-build-4133c8104f52/output/arm64-apple-darwin/bitcoin-4133c8104f52-arm64-apple-darwin.tar.gz
2bf2a112d28ce43e6324538b5588070f75a04a70049545a55a507f829035f614  guix-build-4133c8104f52/output/dist-archive/bitcoin-4133c8104f52.tar.gz
446166729306e764c4be31495cb42e3f1874a7cead37c43d353563d050d8e20d  guix-build-4133c8104f52/output/powerpc64-linux-gnu/SHA256SUMS.part
8ac44fd4e6b4b4f0d8a0a600fd02eb7a77407d911f8f8ee1e8d67a401076e16e  guix-build-4133c8104f52/output/powerpc64-linux-gnu/bitcoin-4133c8104f52-powerpc64-linux-gnu-debug.tar.gz
45a7cda2cd55a253611105e47314b8aa54ba05304a6e0ab913434b17613d96d8  guix-build-4133c8104f52/output/powerpc64-linux-gnu/bitcoin-4133c8104f52-powerpc64-linux-gnu.tar.gz
be2bb897ab2eeb5b0dc6069a568b1765d25bbbc9f8a81ff94893864050feb9e0  guix-build-4133c8104f52/output/powerpc64le-linux-gnu/SHA256SUMS.part
c8d9bbf6a19294ee97317f61a0798effb05d6b5fb016a5d585ab0f33724cd715  guix-build-4133c8104f52/output/powerpc64le-linux-gnu/bitcoin-4133c8104f52-powerpc64le-linux-gnu-debug.tar.gz
f012b8570dcb60c018b1af7be4cb0c65d09881537ff7ce890727b90d30554cce  guix-build-4133c8104f52/output/powerpc64le-linux-gnu/bitcoin-4133c8104f52-powerpc64le-linux-gnu.tar.gz
95b75d7442205a95040dc8c9002bfd9bc9f361eb2db8f9c0fa5380796fc2ce7b  guix-build-4133c8104f52/output/riscv64-linux-gnu/SHA256SUMS.part
626de2b5d5459854165063a7dc0e452f69916c5108e6f15dec01f0121ddd0652  guix-build-4133c8104f52/output/riscv64-linux-gnu/bitcoin-4133c8104f52-riscv64-linux-gnu-debug.tar.gz
0bb2d4d10e584f668722fc9c00593a3194eccec44e4c085c73e88425859e9cff  guix-build-4133c8104f52/output/riscv64-linux-gnu/bitcoin-4133c8104f52-riscv64-linux-gnu.tar.gz
c8af6dea25beeb28fdef8e04fe5fde875ce0dbae38a8c038a5a59f699ef303bc  guix-build-4133c8104f52/output/x86_64-apple-darwin/SHA256SUMS.part
10c07f6b9e3df63a4772741d4bb246f9794db92b0af8f6b4e765188a6f2b108b  guix-build-4133c8104f52/output/x86_64-apple-darwin/bitcoin-4133c8104f52-x86_64-apple-darwin-unsigned.dmg
ced541daeeb58b403c3a25df9daabe82a3e62ad85dd3a78b5d9495955cce8835  guix-build-4133c8104f52/output/x86_64-apple-darwin/bitcoin-4133c8104f52-x86_64-apple-darwin-unsigned.tar.gz
904c0cc18e24c878629a1a54664a212b008cd72a624e6be204968f2e4676a283  guix-build-4133c8104f52/output/x86_64-apple-darwin/bitcoin-4133c8104f52-x86_64-apple-darwin.tar.gz
2c90a8d1484dc2aa011645e4e3570e606d5be26408d7596e3f70b8dc25e8b055  guix-build-4133c8104f52/output/x86_64-linux-gnu/SHA256SUMS.part
6a74fdba8a848157764c44a382729b1231e8ab52750c0b00d3f54efab3cd98e5  guix-build-4133c8104f52/output/x86_64-linux-gnu/bitcoin-4133c8104f52-x86_64-linux-gnu-debug.tar.gz
b3201f583c816245e61f31efc6d95b5d065a7851844c38d67bb7fe7b4cb85d59  guix-build-4133c8104f52/output/x86_64-linux-gnu/bitcoin-4133c8104f52-x86_64-linux-gnu.tar.gz
45f87b892b49e5a191e283115375b31dc826d82c31f294a34e7d5911efc919c4  guix-build-4133c8104f52/output/x86_64-w64-mingw32/SHA256SUMS.part
3093c885bc5965a22686bcc9fb5a8add270673bbdf3592af855b1ccf14ac95ca  guix-build-4133c8104f52/output/x86_64-w64-mingw32/bitcoin-4133c8104f52-win64-debug.zip
3bd77e190aaa323c4ec75725dd42c3a54b7549d2c95674f5825e2f64b212e8d8  guix-build-4133c8104f52/output/x86_64-w64-mingw32/bitcoin-4133c8104f52-win64-setup-unsigned.exe
adf7f12a65d67941569e1f9a8016c8f18987ace9e02e4f8acadb100c29231941  guix-build-4133c8104f52/output/x86_64-w64-mingw32/bitcoin-4133c8104f52-win64-unsigned.tar.gz
8e915cfc6b4315a7698c411bfddb6956073e58526df36df95368eb4069bf47a5  guix-build-4133c8104f52/output/x86_64-w64-mingw32/bitcoin-4133c8104f52-win64.zip

@fanquake fanquake merged commit 8e7179a into bitcoin:master Mar 29, 2023
@fanquake fanquake deleted the guix_depends_use_gcc_wrappers branch March 29, 2023 11:09
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 29, 2023
4133c81 guix: use gcc tool wrappers (fanquake)

Pull request description:

  This way, correct `--plugin` arguments are passed through.

  This is a prerequisite for LTO (see bitcoin#25391). Split out, to try move things along, as this change is isolated, and should be straight-forward.

ACKs for top commit:
  TheCharlatan:
    ACK [4133c81](bitcoin@4133c81)
  hebasto:
    ACK 4133c81

Tree-SHA512: 4311a72a613cf027bd4490caa29604c985ed455589acd972285f13cbdf4806d2184a4dc6f20cb6f47c3fa751d58bfd0bacc257b87d4a804bf5ecf5b240e4a757
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 14, 2024
4133c81 guix: use gcc tool wrappers (fanquake)

Pull request description:

  This way, correct `--plugin` arguments are passed through.

  This is a prerequisite for LTO (see bitcoin#25391). Split out, to try move things along, as this change is isolated, and should be straight-forward.

ACKs for top commit:
  TheCharlatan:
    ACK [4133c81](bitcoin@4133c81)
  hebasto:
    ACK 4133c81

Tree-SHA512: 4311a72a613cf027bd4490caa29604c985ed455589acd972285f13cbdf4806d2184a4dc6f20cb6f47c3fa751d58bfd0bacc257b87d4a804bf5ecf5b240e4a757
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Jan 15, 2024
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Jan 15, 2024
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 16, 2024
4133c81 guix: use gcc tool wrappers (fanquake)

Pull request description:

  This way, correct `--plugin` arguments are passed through.

  This is a prerequisite for LTO (see bitcoin#25391). Split out, to try move things along, as this change is isolated, and should be straight-forward.

ACKs for top commit:
  TheCharlatan:
    ACK [4133c81](bitcoin@4133c81)
  hebasto:
    ACK 4133c81

Tree-SHA512: 4311a72a613cf027bd4490caa29604c985ed455589acd972285f13cbdf4806d2184a4dc6f20cb6f47c3fa751d58bfd0bacc257b87d4a804bf5ecf5b240e4a757
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 19, 2024
4133c81 guix: use gcc tool wrappers (fanquake)

Pull request description:

  This way, correct `--plugin` arguments are passed through.

  This is a prerequisite for LTO (see bitcoin#25391). Split out, to try move things along, as this change is isolated, and should be straight-forward.

ACKs for top commit:
  TheCharlatan:
    ACK [4133c81](bitcoin@4133c81)
  hebasto:
    ACK 4133c81

Tree-SHA512: 4311a72a613cf027bd4490caa29604c985ed455589acd972285f13cbdf4806d2184a4dc6f20cb6f47c3fa751d58bfd0bacc257b87d4a804bf5ecf5b240e4a757
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 24, 2024
4133c81 guix: use gcc tool wrappers (fanquake)

Pull request description:

  This way, correct `--plugin` arguments are passed through.

  This is a prerequisite for LTO (see bitcoin#25391). Split out, to try move things along, as this change is isolated, and should be straight-forward.

ACKs for top commit:
  TheCharlatan:
    ACK [4133c81](bitcoin@4133c81)
  hebasto:
    ACK 4133c81

Tree-SHA512: 4311a72a613cf027bd4490caa29604c985ed455589acd972285f13cbdf4806d2184a4dc6f20cb6f47c3fa751d58bfd0bacc257b87d4a804bf5ecf5b240e4a757
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 28, 2024
4133c81 guix: use gcc tool wrappers (fanquake)

Pull request description:

  This way, correct `--plugin` arguments are passed through.

  This is a prerequisite for LTO (see bitcoin#25391). Split out, to try move things along, as this change is isolated, and should be straight-forward.

ACKs for top commit:
  TheCharlatan:
    ACK [4133c81](bitcoin@4133c81)
  hebasto:
    ACK 4133c81

Tree-SHA512: 4311a72a613cf027bd4490caa29604c985ed455589acd972285f13cbdf4806d2184a4dc6f20cb6f47c3fa751d58bfd0bacc257b87d4a804bf5ecf5b240e4a757
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jan 31, 2024
Summary:
This way, correct `--plugin` argument are passed through.

This is a prerequisite for LTO (see [[bitcoin/bitcoin#25391 | core#25391]]).

This is a backport of [[bitcoin/bitcoin#27345 | core#27345]]

Depends on D15328

Test Plan: `contrib/guix.guix-build`

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D15329
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Feb 7, 2024
4133c81 guix: use gcc tool wrappers (fanquake)

Pull request description:

  This way, correct `--plugin` arguments are passed through.

  This is a prerequisite for LTO (see bitcoin#25391). Split out, to try move things along, as this change is isolated, and should be straight-forward.

ACKs for top commit:
  TheCharlatan:
    ACK [4133c81](bitcoin@4133c81)
  hebasto:
    ACK 4133c81

Tree-SHA512: 4311a72a613cf027bd4490caa29604c985ed455589acd972285f13cbdf4806d2184a4dc6f20cb6f47c3fa751d58bfd0bacc257b87d4a804bf5ecf5b240e4a757
@bitcoin bitcoin locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants