Skip to content

Commit 2717331

Browse files
hebastofanquake
authored andcommitted
Fix benchmark CSV output
The `SHA256AutoDetect` return output is used, among other use cases, to name benchmarks. Using a comma breaks the CSV output. This change replaces the comma with a semicolon, which fixes the issue. Github-Pull: #33340 Rebased-From: 790b440
1 parent a0e438b commit 2717331

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/crypto/sha256.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -627,7 +627,7 @@ std::string SHA256AutoDetect(sha256_implementation::UseImplementation use_implem
627627
Transform = sha256_x86_shani::Transform;
628628
TransformD64 = TransformD64Wrapper<sha256_x86_shani::Transform>;
629629
TransformD64_2way = sha256d64_x86_shani::Transform_2way;
630-
ret = "x86_shani(1way,2way)";
630+
ret = "x86_shani(1way;2way)";
631631
have_sse4 = false; // Disable SSE4/AVX2;
632632
have_avx2 = false;
633633
}
@@ -641,14 +641,14 @@ std::string SHA256AutoDetect(sha256_implementation::UseImplementation use_implem
641641
#endif
642642
#if defined(ENABLE_SSE41)
643643
TransformD64_4way = sha256d64_sse41::Transform_4way;
644-
ret += ",sse41(4way)";
644+
ret += ";sse41(4way)";
645645
#endif
646646
}
647647

648648
#if defined(ENABLE_AVX2)
649649
if (have_avx2 && have_avx && enabled_avx) {
650650
TransformD64_8way = sha256d64_avx2::Transform_8way;
651-
ret += ",avx2(8way)";
651+
ret += ";avx2(8way)";
652652
}
653653
#endif
654654
#endif // defined(HAVE_GETCPUID)
@@ -682,7 +682,7 @@ std::string SHA256AutoDetect(sha256_implementation::UseImplementation use_implem
682682
Transform = sha256_arm_shani::Transform;
683683
TransformD64 = TransformD64Wrapper<sha256_arm_shani::Transform>;
684684
TransformD64_2way = sha256d64_arm_shani::Transform_2way;
685-
ret = "arm_shani(1way,2way)";
685+
ret = "arm_shani(1way;2way)";
686686
}
687687
#endif
688688
#endif // DISABLE_OPTIMIZED_SHA256

0 commit comments

Comments
 (0)