Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Docs: "Not A Specification" #679

Merged
merged 3 commits into from
Dec 19, 2014
Merged

Conversation

harding
Copy link
Contributor

@harding harding commented Dec 12, 2014

Preview: http://dg0.dtrt.org/en/developer-reference#not-a-specification

Make explicit that the docs are not a specification and never will be:

  • Add a new section to the DevRef entitled "Not A Specification". See preview link above
  • In the first sentence of both the DevGuide and the DevRef, say "but [this] is not a specification", with not a specification linked to the new section.
  • Remove other mentions of specification in the doc

This is inspired by @gmaxwell's recent BitcoinTalk post about protocol standardization. @gmaxwell: I'd appreciate it if you could review the new section preview linked above; it's only 5 short paragraphs.

likely provide consensus code that is more complete, more portable, and
more consistent in diverse environments.

In addition, we also warn you that this documentation has not been
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead the always-visible disclaimer could be updated to be a bit more explicit that the documentation likely still contains many errors (and the "has been written recently" part may not be accurate anymore)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I'll put updating that disclaimer in a separate pull. Thanks!

@ghost1542
Copy link
Contributor

@harding As far as I'm concerned, LGTM, thanks!

@harding
Copy link
Contributor Author

harding commented Dec 13, 2014

@saivann thanks for your review! I think all feedback has been addressed: commit de7d371 changes the "majority" phrasing, I tagged all the old dev docs issues so the past issues link demonstrates the doc's fallibility, and opened pull #680 to update the disclaimer. Thanks again!

@harding
Copy link
Contributor Author

harding commented Dec 16, 2014

Rebased and added the new subhead links to the Not A Specification subsection.

In the absence of critical feedback, I'll merge this around 13:00 UTC Thursday (48 hours from now). Additional reviews, even after the merge, are always appreciated.

@harding harding merged commit 82f00e8 into bitcoin-dot-org:master Dec 19, 2014
harding added a commit that referenced this pull request Dec 19, 2014
@harding harding deleted the nospec branch February 25, 2015 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants