Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Docs: Add Details To Alert Creation Process #962

Merged
merged 2 commits into from
Jul 28, 2015
Merged

Site Docs: Add Details To Alert Creation Process #962

merged 2 commits into from
Jul 28, 2015

Conversation

harding
Copy link
Contributor

@harding harding commented Jul 14, 2015

This is, I think, the last thing left on the todo list from #934

Preview: https://github.com/harding/bitcoin.org/tree/alert-docs#alerts

ghost1542
ghost1542 reviewed Jul 25, 2015
View reviewed changes
README.md
- Saïvann Carignan, [@saivann](https://github.com/saivann), saivann on Freenode
- Dave Harding, [@harding](https://github.com/harding), harding on Freenode
- Wladimir van der Laan, [@laanwj](https://github.com/laanwj), wumpus on Freenode
- Theymos, [@theymos](https://github.com/theymos), theymos on Freenode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed @theymos's email address isn't on his GitHub profile as suggested above. @theymos, is it possible for you to add the information, just in case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost1542
Copy link
Contributor

@harding Except for the comments above, c014e92 LGTM, thanks!

@harding
Copy link
Contributor Author

harding commented Jul 25, 2015

@saivann thanks for catching that mistake, and making that improvement suggestion. Here's what I've done:

  • Rebased to fix a merge conflict
  • Fixed the error
  • Changed alias to shorturl
  • Performed a full build and HTML diff to confirm that all the redirect pages were created at the same locations and that nothing else changed

@ghost1542
Copy link
Contributor

Untested LGTM, thanks!

@harding
Copy link
Contributor Author

harding commented Jul 26, 2015

@saivann thanks!

In the absence of critical feedback, this PR will be merged Tuesday.

@harding harding merged commit ec6c93e into bitcoin-dot-org:master Jul 28, 2015
harding added a commit that referenced this pull request Jul 28, 2015
@harding
Merge pull #962: Site Docs: Add Details To Alert Creation Process
8642c81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Merge Scheduled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harding @ghost1542 @theymos