This repository was archived by the owner on Jun 17, 2022. It is now read-only.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is taken from bitcoin/bitcoin@a844dbe This should be safe and sane, because: * The overloaded members construct temporary copies and pass them on as const UniValue&, which will need to be copied again. Future changes that want to disable UniValue copy constructors will be easier with those members removed. * UniValue constructors are not marked explicit and there are no plans to make them explicit, so this change should not make unrelated future changes harder.
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
May 30, 2022
de4f73ddca Merge bitcoin-core/univalue-subtree#36: Drop overloaded members 076c051488 Drop overloaded members 06265321de Merge bitcoin-core/univalue-subtree#35: Remove get_int/get_int64 in favor of getInt<> 462c503aa4 Remove get_int/get_int64 in favor of getInt<> 68c8f5532d Merge bitcoin-core/univalue-subtree#34: doc: remove TODO 297c53a5ee doc: remove TODO git-subtree-dir: src/univalue git-subtree-split: de4f73ddca40487179e9ed08c6f6aa745d6cbba3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is taken from
https://github.com/bitcoin/bitcoin/pull/15975/commits/a844dbed0ff4bdba014052d7ee83cf6c41879fcbThis should be safe and sane, because:
const UniValue&, which will need to be copied again. Future changes
that want to disable UniValue copy constructors will be easier with
those members removed.
to make them explicit, so this change should not make unrelated future
changes harder.