Replace gen_context.c with a Python implementation #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sipa
force-pushed
the
202104_python_precomp
branch
from
a8cfaf7
to
d1a9d8b
Compare
sipa
force-pushed
the
202104_python_precomp
branch
from
d1a9d8b
to
7c3d27a
Compare
|
Also submitted the test improvements separately as #920. |
|
concept ACK. I think this would work well for rust-bitcoin. |
|
Concept ACK - ran into issues running gen_context when cross-compiling with mingw-w64 while having Wine installed. |
|
As an alternative, @roconnor-blockstream is working on extending gen_context in #956. The plan (in that PR or in a follow up PR) is to simply ship with precomputed headers then, which would removes the need for running gen_context (or python) entirely for all supported builds. |
|
Closing in favor of #988 . |
This was referenced Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need for a separate native toolchain to build
gen_context, and the issues around compilation options affecting one but not the other.Alternative to #918.