Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bitcoin-core/secp256k1
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.7.0
Choose a base ref
...
head repository: bitcoin-core/secp256k1
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 7 commits
  • 7 files changed
  • 5 contributors

Commits on Jul 21, 2025

  1. Configuration menu
    Copy the full SHA
    7ab8b0c View commit details
    Browse the repository at this point in the history
  2. Merge #1708: release cleanup: bump version after 0.7.0

    7ab8b0c release cleanup: bump version after 0.7.0 (Jonas Nick)
    
    Pull request description:
    
      Based on #1707.
    
    ACKs for top commit:
      real-or-random:
        utACK 7ab8b0c
    
    Tree-SHA512: 2eea54938ffa2a2c0503607566cb2900b76d5ff6d6285c65afe6fc09fa8b961f210ad915276618c5f43e3ade55252d6533c4c72a5e12c4db4c30fb20235a88df
    real-or-random committed Jul 21, 2025
    Configuration menu
    Copy the full SHA
    b9313c6 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2025

  1. tests: update Wycheproof files

    Pulls in relevant changes from C2SP/wycheproof#150.
    fanquake committed Jul 25, 2025
    Configuration menu
    Copy the full SHA
    9ea54c6 View commit details
    Browse the repository at this point in the history
  2. Fix typos and spellings

    AdrienUfferte authored and fanquake committed Jul 25, 2025
    Configuration menu
    Copy the full SHA
    5433648 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2025

  1. cmake: Avoid contaminating parent project's cache with BUILD_SHARED_LIBS

    The CMake cache is global in scope. Therefore, setting the standard
    cache variable `BUILD_SHARED_LIBS` can inadvertently affect the behavior
    of a parent project.
    
    This change:
    1. Sets the `BUILD_SHARED_LIBS` cache variable only when libsecp256k1 is
       the top-level project.
    2. Removes the `SECP256K1_DISABLE_SHARED` cache variable. This enables
       parent projects that include libsecp256k1 as a subproject to rely
       solely on standard CMake variables for configuring the library type.
    hebasto committed Jul 27, 2025
    Configuration menu
    Copy the full SHA
    7b07b22 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2025

  1. Merge #1711: tests: update Wycheproof

    5433648 Fix typos and spellings (Adrien Ufferte)
    9ea54c6 tests: update Wycheproof files (fanquake)
    
    Pull request description:
    
    ACKs for top commit:
      real-or-random:
        ACK 5433648
      josibake:
        ACK 5433648
    
    Tree-SHA512: abc39f898263da81b53da5223916f079878d31cca850384dd135ee555e7086ecfdbff1d329bf61438d188d76ad87dc610f119009ad91c0d2f8f3fdf99dc12e7a
    jonasnick committed Jul 29, 2025
    Configuration menu
    Copy the full SHA
    2c076d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2025

  1. Merge #1688: cmake: Avoid contaminating parent project's cache with `…

    …BUILD_SHARED_LIBS`
    
    7b07b22 cmake: Avoid contaminating parent project's cache with BUILD_SHARED_LIBS (Hennadii Stepanov)
    
    Pull request description:
    
      The CMake cache is global in scope. Therefore, setting the standard cache variable `BUILD_SHARED_LIBS` can inadvertently affect the behavior of a parent project.
    
      Consider configuring Bitcoin Core without explicit setting `BUILD_SHARED_LIBS`:
      ```
      $ cmake -B build -DBUILD_KERNEL_LIB=ON
      ```
    
      According to CMake’s documentation, this should configure `libbitcoinkernel` as `STATIC`.
      However, that's not the case:
      ```
      $ cmake --build build -t libbitcoinkernel
      [143/143] Linking CXX shared library lib/libbitcoinkernel.so
      ```
    
      This PR:
      1. Sets the `BUILD_SHARED_LIBS` cache variable only when `libsecp256k1` is the top-level project.
      2. Removes the `SECP256K1_DISABLE_SHARED` cache variable. This enables parent projects that include libsecp256k1 as a subproject to rely solely on standard CMake variables for configuring the library type.  During integration into a parent project, the static library can be forced as demonstrated [here](bitcoin-core/minisketch#75 (comment)).
    
    ACKs for top commit:
      purpleKarrot:
        ACK 7b07b22
      theuni:
        utACK 7b07b22
    
    Tree-SHA512: 399a02e86093656ce70d9a0292a1f30834bcc5b9cf0f77d6465adc5e8a4d8e779684adedc40942eb931fed857399e4176a23fdbdf45f277184b28159fbc932d2
    real-or-random committed Jul 30, 2025
    Configuration menu
    Copy the full SHA
    20e3b44 View commit details
    Browse the repository at this point in the history
Loading