Skip to content

Commit 325d65a

Browse files
committed
Rename and clear var containing k or -k
buf currently holds k or -k and isn't cleared, so clear it and rename to nonce32 to clarify its sensitivity and match how it is named in the corresponding ECDSA sign_inner.
1 parent f36afb8 commit 325d65a

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/modules/schnorrsig/main_impl.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ static int secp256k1_schnorrsig_sign_internal(const secp256k1_context* ctx, unsi
139139
secp256k1_gej rj;
140140
secp256k1_ge pk;
141141
secp256k1_ge r;
142-
unsigned char buf[32] = { 0 };
142+
unsigned char nonce32[32] = { 0 };
143143
unsigned char pk_buf[32];
144144
unsigned char seckey[32];
145145
int ret = 1;
@@ -164,8 +164,8 @@ static int secp256k1_schnorrsig_sign_internal(const secp256k1_context* ctx, unsi
164164

165165
secp256k1_scalar_get_b32(seckey, &sk);
166166
secp256k1_fe_get_b32(pk_buf, &pk.x);
167-
ret &= !!noncefp(buf, msg, msglen, seckey, pk_buf, bip340_algo, sizeof(bip340_algo), ndata);
168-
secp256k1_scalar_set_b32(&k, buf, NULL);
167+
ret &= !!noncefp(nonce32, msg, msglen, seckey, pk_buf, bip340_algo, sizeof(bip340_algo), ndata);
168+
secp256k1_scalar_set_b32(&k, nonce32, NULL);
169169
ret &= !secp256k1_scalar_is_zero(&k);
170170
secp256k1_scalar_cmov(&k, &secp256k1_scalar_one, !ret);
171171

@@ -191,6 +191,7 @@ static int secp256k1_schnorrsig_sign_internal(const secp256k1_context* ctx, unsi
191191
secp256k1_scalar_clear(&k);
192192
secp256k1_scalar_clear(&sk);
193193
secp256k1_memclear(seckey, sizeof(seckey));
194+
secp256k1_memclear(nonce32, sizeof(nonce32));
194195
secp256k1_gej_clear(&rj);
195196

196197
return ret;

0 commit comments

Comments
 (0)