Skip to content

Conversation

@s1Sharp
Copy link

@s1Sharp s1Sharp commented Jan 21, 2024

Fixed widget names in the debug window. Make it more developer friendly to avoid confusion inside Qt Designer.

@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 21, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@s1Sharp
Copy link
Author

s1Sharp commented Jan 21, 2024

Qt Designer view before changes:
image
Qt Designer view after changes:
image

And a few changes for other widget names that were not included in the screenshots.

Also property indent is unnessasary for QLabel: labelClientUserAgent

         <property name="indent">
          <number>10</number>
         </property>

@hebasto
Copy link
Member

hebasto commented Jan 22, 2024

@s1Sharp

Thank you for your contribution!

However, I'm going to close this PR following our CONTRIBUTING Guide and to avoid unnecessary conflicts with other PRs.

@hebasto hebasto closed this Jan 22, 2024
@bitcoin-core bitcoin-core locked and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants