Fix misleading RPC console wallet message

[john-moffett]

Misleading message from RPCConsole window

In certain circumstances, the GUI console will display the message 'Executing command without any wallet' when it is, in fact, using the currently loaded wallet. For instance:

In RPC calls, if no wallet is explicitly selected and there is exactly one wallet loaded, the default is to act on that loaded wallet.

The GUI console acts that way in reality, but sometimes erroneously reports that it's not acting on any particular wallet. The root issue is due to the logic that prevents changing the selected wallet if the RPCConsole is visible:

gui/src/qt/rpcconsole.cpp

Lines 783 to 786 in 39363a4

	if (ui->WalletSelector->count() == 2 && !isVisible()) {
	// First wallet added, set to default so long as the window isn't presently visible (and potentially in use)
	ui->WalletSelector->setCurrentIndex(1);
	}

This PR removes that unnecessary logic. This does have some ramifications. Prior to this PR, if a user opened the console window without any wallets loaded, then opened two or more wallets, the RPC console would select "None" of the wallets and any wallet-specific RPCs would fail. However, the behavior was different if the user hadn't had the console window open. In that case, if they opened the RPC Console window after loading at least the first wallet, it would select the first-loaded wallet. This context-dependent behavior is (IMO) undesirable, and this PR changes it to be consistent.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

[hebasto]

Confirming the bug on Ubuntu 22.04 (Qt 5.15.3).

Concept ACK.

[hebasto]

ACK 576f7b8, tested on Ubuntu 22.04 (Qt 5.15.3).

This patch also fixes another buggy behavior for me. Steps to reproduce it on the master branch:

1. Run bitcoin-qt -nowallet.
2. Open the "Console" tab of the "Node window".
3. Open a wallet.
4. Run getwalletinfo in the "Console" tab -- BUG: No "Executing command using..." message.
5. Open another wallet.
6. The wallet selector in the "Console" tab has the "none" value. Not a bug(?), but unexpected behavior (already mentioned in the PR description).