about:version:help clean up add Bitcoin branding #140

RandyMcMillan · 2020-11-29T08:17:23Z

Before:

After:

Updated default presentations:

RandyMcMillan · 2020-11-29T08:30:20Z

src/init.cpp

+    return CopyrightHolders(strprintf(_("Copyright (C) %i-%i").translated, 2009, COPYRIGHT_YEAR) + " ");
+}
+
+std::string AboutMessageInfo()


The AboutMessageInfo() is simple and can be modified more easily in the future.

RandyMcMillan · 2020-11-29T08:33:19Z

src/qt/bitcoin.qrc

@@ -44,6 +44,7 @@
        <file alias="hd_disabled">res/icons/hd_disabled.png</file>
        <file alias="network_disabled">res/icons/network_disabled.png</file>
        <file alias="proxy">res/icons/proxy.png</file>
+        <file alias="bitcoin_core">res/icons/bitcoin_core.png</file>


Added the png art that is used in the header of the about view.

Reuse of bitcoin.png is a better approach. Thanks for the feed back!

RandyMcMillan · 2020-11-29T08:34:14Z

src/qt/forms/helpmessagedialog.ui

@@ -6,10 +6,13 @@
   <rect>
    <x>0</x>
    <y>0</y>
-    <width>780</width>
-    <height>400</height>
+    <width>602</width>


The new configuration makes a better use of space - therefore the window doesn't need to open as big.

The view's dimensions are now dynamic and resize based on help/about context.

RandyMcMillan · 2020-11-29T08:35:41Z

src/qt/utilitydialog.cpp

@@ -41,21 +41,37 @@ HelpMessageDialog::HelpMessageDialog(QWidget *parent, bool about) :
        setWindowTitle(tr("About %1").arg(PACKAGE_NAME));

        std::string licenseInfo = LicenseInfo();
-        /// HTML-format the license message from the core
+        std::string copyrightInfo = CopyrightInfo();


The new implementation separates these strings.

REF: e0ff8e2#r536346038

hebasto · 2020-11-29T08:45:17Z

NACK on changes of -version command-line argument output layout.

jarolrod · 2020-11-29T23:03:45Z

These two sections should be aligned

RandyMcMillan · 2020-12-01T04:48:46Z

@hebasto

I ensured that the output is uniform for -version (except for the word "version" in bitcoind -version)

I would prefer to take it out.. I believe v implies version and is redundant.

thanks for the feedback! :)

jonasschnelli · 2020-12-01T09:34:44Z

I like the new style.
Though there is still a debate on whether the logo should be orange or black.
#89

Concept ACK if we keep the color as is (we can always change it later to black if people want this).

Bosch-0 · 2020-12-03T05:00:43Z

Concept ACK

The updated screenshots you posted above, the text should align with the logo such as below.

bitcoinheiro · 2020-12-03T08:23:28Z

I would change that logo. This is Bitcoin, Core is secondary. Only forks want to reinforce the Core over Bitcoin.

Orange logo
Bitcoin bold
Core thin

Bosch-0 · 2020-12-03T08:27:41Z

I would change that logo. This is Bitcoin, Core is secondary. Only forks want to reinforce the Core over Bitcoin.

I disagree with this view. The GUI this repo is for is a product developed by Core that uses the Bitcoin protocol. Other implementations may one day exist that work on Bitcoin that aren't Core.

bitcoinheiro · 2020-12-03T08:57:38Z

What do we want to communicate?
Do we want to have more force on the name Bitcoin or Core?

We cannot be always thinking about other people concerns, the software is what it is and other implementations can exist - and they do exist - without the need to reinforce this concept on the logo and be "apologetic".

I believe users of the Core implementation should feel they are running BITCOIN when running this "product" and not "Core".
When I see the black logo it makes me feel sad, it confuses me instead of reinforcing Bitcoin. Feels like you're putting Bitcoin "in the closet" and we should be ashamed to be Bitcoin instead of proud of it.

Bosch-0 · 2020-12-03T09:05:01Z

Do we want to have more force on the name Bitcoin or Core?

One or the other at this stage - currently both are used and its confusing.

I believe users of the Core implementation should feel they are running BITCOIN

You can still achieve this whilst using the black logo - do people think they are running something else when using products like electrum or bluewallet? I'd say no. This is the designers job to communicate this effectively and use the black and orange logos in their appropriate locations.

Do most people see Bitcoin Core = Bitcoin?

bitcoinheiro · 2020-12-03T09:13:53Z

Do most people see Bitcoin Core = Bitcoin?
I believe people do and you're exactly trying to use the design to communicate otherwise.
I don't think people have to be communicated otherwise.

Why Bitcoin so thin and Core so bold? Isn't that trying to communicate Core over Bitcoin?
This project is not Electrum or BlueWallet, it's Bitcoin.

Bosch-0 · 2020-12-03T09:18:26Z

I've already explained my rationale many times above.

I'm still of the thought that:

Bitcoin Core is a group of developers who work on Bitcoin.

Bitcoin is a network that everyone is apart of.

Electrum and BlueWallet are part of the Bitcoin ecosystem as is the GUI developed by the Core developers.

jonatack · 2020-12-03T09:27:40Z

I agree with not emphasizing "Core". Let's not institutionalize that emphasis further. Please keep them equal or put more weight on "Bitcoin".

One of my pet peeves is people writing "Core" instead of "Bitcoin Core" ("Core devs", "running Core", and so on).

See the Bitcoin Optech style guide:

Forbidden abbreviations:

Core (use Bitcoin Core)

100% agree with our Bitcoin Optech colleagues about this.

jonasschnelli · 2020-12-03T09:59:07Z

Don't get me wrong. I originally designed the black logo and I like it.
Though @gmaxwell made a valid comment here.

Changing the color might have greater impact than originally anticipated.

jonatack · 2020-12-03T10:15:28Z

Concept ACK, sorry about not reviewing the PR itself, in general this looks very nice @RandyMcMillan and is a good improvement.

promag

I'd be happy to ACK everything but the logo change, maybe you want to split the PR?

RandyMcMillan · 2020-12-03T22:40:35Z

Thank you for the feed back!

RandyMcMillan · 2020-12-03T22:47:37Z

I agree with the statement

The Bitcoin Core Developers

is a group and this is why I've maintained that "Developers" should be capitalized in the branding.

Further more...

From a copyright perspective - THE BITCOIN CORE DEVELOPERS should be in all caps - but this isn't mandated in any legalese that I have read...

But that is outside the scope of this PR. :)

RandyMcMillan · 2020-12-04T00:27:47Z

I didn't see the link - agree.

#89 (comment)

The logo should remain orange. This change would inadvertantly play into efforts to create a false equivalence between Bitcoin and various fraudulent clones.

We now know through leaked emails that even the renaming of Bitcoin Core to that name was dishonestly driven by malicious intent-- the parties that pushed for the name change did so because they were intending to attempt to take over Bitcoin from the community and move it under their control, and they wanted to "other" the community project and disassociate it with Bitcoin. Going along with it was an error. It's water under the bridge now but there is no reason to continue being victimized by past wrongs and compounding a past error.

jarolrod

Tested ACK 5210082
NACK on the current logo text, it looks really bad IMO.

Also the about page and command-line options page don't need to be the same size. There's a lot of unused space in the about page because they're set to be the same size.

RandyMcMillan · 2020-12-04T02:18:00Z

@jarolrod - please add some context to the pic you posted.
OS - Screen resolution - dark theme? etc...
Thanks.

jarolrod · 2020-12-04T02:25:28Z

@jarolrod - please add some context to the pic you posted.
OS - Screen resolution - dark theme? etc...
Thanks.

OS: Arch Linux, DE: KDE Plasma 5.19.5, Res:3440x1440
The picture is pixelated because its cropped. Below is the full photo. I was trying to point out that everything looks off. The Bitcoin logo is in a weird position in relation to the logo text and the seperator bar. The logo text appears to have weird spacing. I'm not a designer, but this looks off to me.

RandyMcMillan · 2020-12-04T03:52:58Z

Removed excessive space in the aboutMessage body.
These are the default dimensions when they first appear.

RandyMcMillan · 2020-12-04T19:30:09Z

src/qt/bitcoingui.cpp

@@ -846,6 +846,7 @@ void BitcoinGUI::showDebugWindowActivateConsole()
 void BitcoinGUI::showHelpMessageClicked()
 {
    helpMessageDialog->show();
+    helpMessageDialog->raise();//bring to top if obscured


If the helpMessageDialog has already been presented - this change brings it to the front if the user re-clicks on the help menu item - otherwise it may remain obscured by any other windows.

RandyMcMillan · 2020-12-04T19:35:32Z

src/qt/utilitydialog.cpp

@@ -33,29 +33,46 @@ HelpMessageDialog::HelpMessageDialog(QWidget *parent, bool about) :
    ui(new Ui::HelpMessageDialog)
 {
    ui->setupUi(this);
-
+    this->resize(500,0);//force view height to stretch


The Ui::HelpMessageDialog is shared with the about view.
These change forces the view to stretch to an appropriate height - this eliminates excessive height dimensions - the user resizes based upon personal preference.

RandyMcMillan · 2020-12-04T19:42:46Z

src/qt/utilitydialog.cpp

+
+    if (about)
+    {
+        setWindowTitle(tr("About %1").arg(PACKAGE_NAME));


Over riding PACKAGE_NAME is outside the scope of this PR.

This PR is implementing changes based on broader community discussions and sentiment.

REF: #89 (comment)

REF: #140 (comment)

RandyMcMillan · 2020-12-04T19:54:55Z

src/bitcoind.cpp


        if (args.IsArgSet("-version")) {
-            strUsage += FormatParagraph(LicenseInfo()) + "\n";
+            strUsage += FormatParagraph(LicenseInfo()) + "\n" + CopyrightInfo() + "\n";//from init.cpp


bitcoind.cpp uses the same strings that help and about use.
LicenseInfo() and CopyrightInfo() are now refactored for reusability.

RandyMcMillan · 2020-12-04T19:57:59Z

src/clientversion.cpp

@@ -47,6 +47,11 @@ static std::string FormatVersion(int nVersion)
    return strprintf("%d.%d.%d", nVersion / 10000, (nVersion / 100) % 100, nVersion % 100);
 }

+std::string FormatVersion()


Returns a terse string for reusability.
REF: e0ff8e2#r536344384

RandyMcMillan · 2020-12-04T20:22:14Z

Updated default presentations:

jonasschnelli · 2020-12-07T08:24:49Z

src/qt/bitcoin.qrc

@@ -1,4 +1,4 @@
-<!DOCTYPE RCC><RCC version="1.0">
+<RCC>


is this change necessary

Corrected - Qt should have never changed that.
https://doc.qt.io/qt-5.12/qtxmlpatterns-schema-schema-qrc.html
Unexpected behavior.

jonasschnelli · 2020-12-07T08:26:35Z

src/qt/utilitydialog.cpp

        QString licenseInfoHTML = QString::fromStdString(LicenseInfo());
        // Make URLs clickable
        QRegExp uri("<(.*)>", Qt::CaseSensitive, QRegExp::RegExp2);
        uri.setMinimal(true); // use non-greedy matching
+        versionInfoHTML.replace(uri, "<a href=\"\\1\">\\1</a>");


why does it create a link here?

You are correct! This string no longer needs this transform.
Awesome!

RandyMcMillan · 2020-12-08T03:37:45Z

src/bitcoind.cpp

+            strUsage += FormatParagraph(LicenseInfo()) + "\n"
+                "\nUsage:  bitcoind [options]                     Start " PACKAGE_NAME "\n"
+                "\n";
+            strUsage += args.GetHelpMessage();
        }


Resolved conflict.

Rspigler · 2020-12-12T01:38:20Z

Whether I agree with the change or not, I don't see how it can be appropriate to slip in a name change. Either the PR title should be changed, or a new PR created IMO. It also doesn't make sense to me to have the name be Bitcoin Core on the loading screen, as well as Help->About Bitcoin Core yet then the about page say Bitcoin (without Core). It's just more inconsistency.

We also have other issues underway on branding discussing this issue that aren't cleared yet (#89, #100). There's a lot of inconsistency. Bitcoin.org uses orange; bitcoincore.org uses both; bitcoin repo uses black; bitcoin-core repo uses orange. And now we're making additional naming changes before any decisions have been made. Seems very messy.

RandyMcMillan · 2020-12-14T18:35:19Z

@Rspigler - I agree it is a pretty serious issue...

There is a lot to do - and lot of decisions to be made.
This emphasizes the importance of a formal specification for branding/logo usage.

And yes...the scope of this PR has changed.

More importantly is - Working on the Gui has led me to believe there is a relatively easy work around to abstracting the Gui variables (PROJECT_NAME, etc..) from the build environment variables so Gui dev can progress and the plumbing can be refactored independently...

So once I know which direction to go concerning naming/branding/logo/etc...
How to proceed should be clearer...

RandyMcMillan commented Nov 29, 2020

View reviewed changes

RandyMcMillan marked this pull request as draft December 2, 2020 16:55

RandyMcMillan mentioned this pull request Dec 3, 2020

[Discussion] Bitcoin Core logo #89

Open

promag reviewed Dec 3, 2020

View reviewed changes

jarolrod reviewed Dec 4, 2020

View reviewed changes

RandyMcMillan marked this pull request as ready for review December 4, 2020 04:01

RandyMcMillan changed the title ~~about-view: clean up - Bitcoin Core logo~~ about-view: clean up - Bitcoin branding Dec 4, 2020

RandyMcMillan commented Dec 4, 2020

View reviewed changes

jonasschnelli reviewed Dec 7, 2020

View reviewed changes

DrahtBot added the Needs rebase label Dec 7, 2020

RandyMcMillan mentioned this pull request Dec 8, 2020

bitcoind -h help logic broken bitcoin/bitcoin#20596

Closed

RandyMcMillan commented Dec 8, 2020

View reviewed changes

DrahtBot removed the Needs rebase label Dec 8, 2020

RandyMcMillan changed the title ~~about-view: clean up - Bitcoin branding~~ about:version:help clean up add Bitcoin branding Dec 8, 2020

RandyMcMillan added 2 commits December 8, 2020 03:17

test: feature_help.py test for essential elements

fcfc212

about:version:help clean up add bitcoin branding

42b05fe

RandyMcMillan marked this pull request as draft December 8, 2020 18:30

Rspigler mentioned this pull request Dec 12, 2020

splash: New layout #147

Closed

RandyMcMillan closed this Jan 23, 2021

bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022

about:version:help clean up add Bitcoin branding #140

about:version:help clean up add Bitcoin branding #140

Uh oh!

Conversation

RandyMcMillan commented Nov 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan Nov 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hebasto commented Nov 29, 2020

Uh oh!

jarolrod commented Nov 29, 2020

Uh oh!

RandyMcMillan commented Dec 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonasschnelli commented Dec 1, 2020

Uh oh!

Bosch-0 commented Dec 3, 2020

Uh oh!

bitcoinheiro commented Dec 3, 2020

Uh oh!

Bosch-0 commented Dec 3, 2020

Uh oh!

bitcoinheiro commented Dec 3, 2020

Uh oh!

Bosch-0 commented Dec 3, 2020

Uh oh!

bitcoinheiro commented Dec 3, 2020

Uh oh!

Bosch-0 commented Dec 3, 2020

Uh oh!

jonatack commented Dec 3, 2020

Uh oh!

jonasschnelli commented Dec 3, 2020

Uh oh!

jonatack commented Dec 3, 2020

Uh oh!

promag left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan commented Dec 3, 2020

Uh oh!

RandyMcMillan commented Dec 3, 2020

Uh oh!

RandyMcMillan commented Dec 4, 2020

Uh oh!

jarolrod left a comment

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan commented Dec 4, 2020

Uh oh!

jarolrod commented Dec 4, 2020

Uh oh!

RandyMcMillan commented Dec 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RandyMcMillan Dec 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan Dec 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan commented Nov 29, 2020 •

edited

Loading

RandyMcMillan Nov 29, 2020 •

edited

Loading

RandyMcMillan commented Dec 1, 2020 •

edited

Loading

promag left a comment •

edited

Loading

RandyMcMillan commented Dec 4, 2020 •

edited

Loading

RandyMcMillan Dec 4, 2020 •

edited

Loading

RandyMcMillan Dec 4, 2020 •

edited

Loading

RandyMcMillan Dec 7, 2020 •

edited

Loading