macOS 11 (Big Sur) visual bugs

[jonasschnelli]

Nighy build on Big Sur "dark mode":

Self compiled on Big Sur "night mode" with depends:

Two major issues:

• disabling the night mode color palette or adopt it correctly (probably a QT upstream issue)
• get rid of the white glitch in the debug-window tab-bar-menu

Qt upstream issue: https://bugreports.qt.io/browse/QTBUG-85546

[mjdietzx]

I also noticed what seems to be a bug on Big Sur. When I go to send a transaction from my encrypted wallet, I get a popup that says "Unlock wallet". I enter the correct passphrase, but no matter what the "OK" button stays disabled and can't be clicked. Usually I'd expect once you enter at least 1 char into the passphrase input, that button would become enabled/clickable

[goums]

I've tried to update the QPalette and the styleSheet of the widgets to fix the display glitches, but I didn't manage to fix them as the bugs are directly in the QMacStyle widgets implementations.

The QT team is working on it, but the underlying QT issues will probably take some time to be resolved and is tagged for QT6:
https://bugreports.qt.io/browse/QTBUG-86513

So one solution instead of waiting for QT6 release (and hoping for QMacStyle to be fixed) could be to force QApplication to use the default "Fusion" style on macos:
https://doc.qt.io/qt-5/gallery.html

This is a one line change, no added dependencies, and it supports Light / Dark modes out of the box.

• Some screenshots using Fusion on DarkMode :
  
  
  
  
  

• Some screen shot using Fusion on Light Mode :
  
  
  
  

[jonasschnelli]

@goums: can the fusion style be a runtime option? Or even a startup ENV parameter?

[goums]

Yes, according to the doc, it can be either set with a command line argument or an environment variable.
https://doc.qt.io/qt-5/qapplication.html#QApplication

I got an error Invalid parameter -style if I try to add it to the command line, but it works nice if I use the environment variable: QT_STYLE_OVERRIDE =fusion.

It can be set on the Project > Build & Run > Run > Environment :

NB: you need to fetch #154 to have the icon colorized on macos dark mode

[hebasto]

@jonasschnelli

@goums: can the fusion style be a runtime option? Or even a startup ENV parameter?

I think the former is disabled since bitcoin/bitcoin#16578.