Skip to content

Commit 5c041cb

Browse files
committed
Merge #311: Peers Window rename 'Peer id' to 'Peer'
657b33e qt: add translator comments for peers table columns (Jarol Rodriguez) 73a91c6 gui: rename "Peer Id" to "Peer" in tab column and details area (Jon Atack) Pull request description: Picking up #290 **Original PR Description:** - renames the peers tab column header from `Peer Id` to `Peer` to allow resizing the column more tightly (this will be particularly useful after #256) and does the same for the peer details area. While here, we also add Qt translator comments for the Peer Table columns. | Master | PR | | ----------- | ----------- | | ![Screen Shot 2021-05-03 at 1 23 05 AM](https://user-images.githubusercontent.com/23396902/116843818-20a14b00-abaf-11eb-913e-ddff11cda5cd.png) | ![Screen Shot 2021-05-05 at 4 08 45 AM](https://user-images.githubusercontent.com/23396902/117112825-a2cc7380-ad57-11eb-939b-1aceb4214ad1.png) | ACKs for top commit: jonatack: utACK 657b33e hebasto: re-ACK 657b33e Tree-SHA512: f50116f7ca8719cadf1f95f45e3594b3b92bde9c43eb954f3e963ed10629dd9406efdb5e96aa1f750a926e24a96321d824ed3780bd9cd748774e0b85fd0c9535
2 parents 456c8d6 + 657b33e commit 5c041cb

File tree

2 files changed

+26
-2
lines changed

2 files changed

+26
-2
lines changed

src/qt/peertablemodel.h

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,31 @@ public Q_SLOTS:
7474

7575
private:
7676
interfaces::Node& m_node;
77-
const QStringList columns{tr("Peer Id"), tr("Address"), tr("Type"), tr("Network"), tr("Ping"), tr("Sent"), tr("Received"), tr("User Agent")};
77+
const QStringList columns{
78+
/*: Title of Peers Table column which contains a
79+
unique number used to identify a connection. */
80+
tr("Peer"),
81+
/*: Title of Peers Table column which contains the
82+
IP/Onion/I2P address of the connected peer. */
83+
tr("Address"),
84+
/*: Title of Peers Table column which describes the type of
85+
peer connection. The "type" describes why the connection exists. */
86+
tr("Type"),
87+
/*: Title of Peers Table column which states the network the peer
88+
connected through. */
89+
tr("Network"),
90+
/*: Title of Peers Table column which indicates the current latency
91+
of the connection with the peer. */
92+
tr("Ping"),
93+
/*: Title of Peers Table column which indicates the total amount of
94+
network information we have sent to the peer. */
95+
tr("Sent"),
96+
/*: Title of Peers Table column which indicates the total amount of
97+
network information we have received from the peer. */
98+
tr("Received"),
99+
/*: Title of Peers Table column which contains the peer's
100+
User Agent string. */
101+
tr("User Agent")};
78102
std::unique_ptr<PeerTablePriv> priv;
79103
QTimer *timer;
80104
};

src/qt/rpcconsole.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1049,7 +1049,7 @@ void RPCConsole::updateDetailWidget()
10491049
const auto stats = selected_peers.first().data(PeerTableModel::StatsRole).value<CNodeCombinedStats*>();
10501050
// update the detail ui with latest node information
10511051
QString peerAddrDetails(QString::fromStdString(stats->nodeStats.addrName) + " ");
1052-
peerAddrDetails += tr("(peer id: %1)").arg(QString::number(stats->nodeStats.nodeid));
1052+
peerAddrDetails += tr("(peer: %1)").arg(QString::number(stats->nodeStats.nodeid));
10531053
if (!stats->nodeStats.addrLocal.empty())
10541054
peerAddrDetails += "<br />" + tr("via %1").arg(QString::fromStdString(stats->nodeStats.addrLocal));
10551055
ui->peerHeading->setText(peerAddrDetails);

0 commit comments

Comments
 (0)