Replace use of boost::trim_right with locale-independent TrimString

Empact · fanquake · commit 4bf18b089e1b · 2021-09-02T13:19:42.000+08:00
Note the only use of readStdin is fed to DecodeHexTx, which fails in
IsHex on non-hex characters as recorded in p_util_hexdigit.
diff --git a/src/bitcoin-tx.cpp b/src/bitcoin-tx.cpp
@@ -772,9 +772,7 @@ static std::string readStdin()
     if (ferror(stdin))
         throw std::runtime_error("error reading stdin");
 
-    boost::algorithm::trim_right(ret);
-
-    return ret;
+    return TrimString(ret);
 }
 
 static int CommandLineRawTx(int argc, char* argv[])
diff --git a/test/lint/lint-locale-dependence.sh b/test/lint/lint-locale-dependence.sh
@@ -39,7 +39,6 @@ export LC_ALL=C
 
 KNOWN_VIOLATIONS=(
     "src/bitcoin-tx.cpp.*stoul"
-    "src/bitcoin-tx.cpp.*trim_right"
     "src/dbwrapper.cpp.*stoul"
     "src/dbwrapper.cpp:.*vsnprintf"
     "src/node/blockstorage.cpp:.*atoi"

Original file line number	Diff line number	Diff line change
`@@ -772,9 +772,7 @@ static std::string readStdin()`
`772`	`772`	`if (ferror(stdin))`
`773`	`773`	`throw std::runtime_error("error reading stdin");`
`774`	`774`
`775`		`- boost::algorithm::trim_right(ret);`
`776`		`-`
`777`		`- return ret;`
	`775`	`+ return TrimString(ret);`
`778`	`776`	`}`
`779`	`777`
`780`	`778`	`static int CommandLineRawTx(int argc, char* argv[])`