Bump Ruby to 2.7.4, update github-pages and html-proofer gems #826
Conversation
|
Concept ACK. It makes sense to use a supported version of Ruby for easier local reproducibility. |
This comment was marked as outdated.
This comment was marked as outdated.
|
I'm planning not to wipe my Buster hosts out until summer, sorry. On the bright side, summer's almost here! 🏖️ |
|
I'll wait for that to be merged |
04e9f6b README: add --check-html to htmlproofer (Sjors Provoost) 488ae09 Satisfy newer html-proofer (Sjors Provoost) Pull request description: Cherry-picks two commits from #826 (which needs rebase, and is dependant on infra updates), which are correct, and can be merged now. ACKs for top commit: stickies-v: ACK 04e9f6b Tree-SHA512: 84048d6acd9126c75583e5d891a737e9ff65652ac8f30df160d66487d858ce5b917d401edbf73c0c882c4139bc7f63ff07c0790cc612fd5762c40603a4d9beba
Ruby 2.5 is EOL and Debian Stable ships 2.7.4
The github-pages and html-proofer gems we use are not specified by semver, so this just bumps them to their most recent versions: * github-pages: 202 to 222 * html-proofer: 3.14.1 to 3.19.2
|
Rebased. I can bump the Ruby (patch) version further if we want to use a more modern version of Debian. |
There was a problem hiding this comment.
ACK bda840a
Tested locally on macOS. This also should fix CI failures on important updates like #957
Show Signature
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
ACK bda840a988310629ab677370c80ec93eb3df6ec5
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAmQhx1MACgkQ5+KYS2KJ
yTqzgBAAiqilomgkqdJ02zQeySa/avQVQFl0MRMyutvtW/3Hayvdhg5YNKBqlyvn
gAgVjhMP/RKA2nfJPdeWiXzb9JiRoURJHqqtRbWXL5Gi/F9idfPkEqp28qSklPX4
ZgMZU5hWIHsqjy5Q9t7p4cer6qDxAJaUk2+0TwaXfVvkSTHQzVJr9/juefh21wJR
jDXHaynqjb+jUF3C4gyAbJmIlptffdQJ/uE3iZJJHNixJP+W6sN55RbIogwNO8lA
HaKhhYOaYXUtKDweKFl0S5WmTwltG3w6j/3nTXrYS9OqglGXfU3l9l5PQ/+Go/09
0ie+d4XBMrUyGN/1vDEyW1cXqK7V5CSbYyG6CtjvJbkQZrBSLHEX/jMzMkfa35j7
KpxP2FrLISG9lIlqram+LauhC3SMMm1JcRRkB5OcVflGQjbCLHgl54EBSnDp3+hO
ZGHgKVe9j1PhnWc7KsdH3jAgJLjHKb949VpZRl5vMgb5xxPl5NkAQEWucAeZYqGC
dNykxNofS28bflEjzRLpy38BceNiPjm3+2KXSD4ZA8m29phKVANSOQPNzhNC4mgU
QBsviGw+Q+MtM4BUbNmAPaeG5Fn87X+wB93hK9zS9MMkvmnFtaKryuAc6WOFY8+L
BkvCFK6WIq1SF8/Pg9MRXnuVL7CWyZEBev/gEQu2/l7uKpijs1w=
=Dy6W
-----END PGP SIGNATURE-----
pinheadmz's public key is on keybase
|
Going to merge this just in time for Ruby |
|
I'll make a PR to bump to 2.7.8 so we can stay on the bleeding edge of the EOL. Any gems that need bumping? |
|
There's no need for a PR. As as far as I'm aware, that version of ruby won't be available. |
|
Mmm, the release mentions it fixes security issues. Anyway, I can (also) make a PR to the 3.1 or 3.2 series. That involves a bit more testing though. |
This requires updating the server to Debian Stable Bullseye, cc TheBlueMatt.
I tested a few pages locally and didn't notice any difference.
I also ran the
htmlprooferincantation from the README, which I updated to matchMakefile. Only one minor change was needed to satisfy the updated version.Closes #825