Skip to content

Recent posts to show published date #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2022

Conversation

JijoBose
Copy link
Contributor

@JijoBose JijoBose commented Sep 4, 2021

Recent posts to show published date

Fixes #488

  • Added published date to the recent posts

Screen Shot 2021-09-04 at 12 20 47 PM

@JijoBose JijoBose force-pushed the 488-recent-post-date branch 2 times, most recently from 7673921 to 179e2ad Compare September 24, 2021 08:04
@JijoBose JijoBose force-pushed the 488-recent-post-date branch from 2762471 to 6921359 Compare October 5, 2021 16:35
@katesalazar
Copy link
Contributor

katesalazar commented Oct 19, 2021

Concept ACK,
have you made sure this doesn't have to guard
null or empty page.date and post.date?
Have you made sure this doesn't spill to post or page types
where this hasn't been requested?

Code review ACK,
tested ACK

@harding
Copy link
Contributor

harding commented Jan 8, 2022

Tested ACK 6921359 Thanks!

@harding harding merged commit 0b88574 into bitcoin-core:master Jan 8, 2022
@JijoBose JijoBose deleted the 488-recent-post-date branch January 13, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent posts not show dates
3 participants