fix(gui): Crash in "Manage profiles" dialog when using "qt6ct"

Fix #2128

Author: buhtz

CHANGES

@@ -1,3 +1,4 @@
+
 Back In Time
 
 Version 1.6.0-dev (development of upcoming release)
@@ -17,6 +18,7 @@ Version 1.6.0-dev (development of upcoming release)
 * Fixed: Re-design about dialog (#1936)
 * Fixed: Stop waking up monitor when inhibit suspend on backup starts (#714, #1090)
 * Fixed: Avoid shutdown confirmation dialog on Budgie and Cinnamon desktop environments (#788)
+* Fixed: Crash in "Manage profiles" dialog when using "qt6ct" (#2128)
 
 Version 1.5.4 (2025-03-24)
 * Breaking Change: Auto-remove rules "Free inodes" and "Free space" disabled by default in new created profiles (#1976)

doc/maintain/BiT_release_process.md

@@ -325,15 +325,23 @@ expected. The following list suggests several actions and scenarios.
   or distros based on them. Additionally use a none-systemd distro like _Devuan
   GNU/Linux_.
 - Run _Back In Time_ and perform the following actions as user and as root.
-- Always start from terminal to catch silent errors and warnings.
-- Create snapshot profils in all available flavors (Local, SSH, with and
-  without encryption).
-- Run the snapshots.
-- Restore snapshots.
-- Delete snapshots.
-- Schedule the snapshots using regular cron (e.g. _Every 5 minutes_) and
-  anacron-like cron (_Repeatedly (anacran)_). Additionally schedule with udev
-  (_When drive gets connected (udev)_).
+  - Always start from terminal to catch silent errors and warnings.
+  - Create backup profils in all available flavors (Local, SSH, each with and
+    without encryption).
+  - Take backup.
+  - Restore backup.
+  - Delete backup.
+  - Schedule backups using
+    - regular cron (e.g. _Every 5 minutes_)
+    - anacron-like cron (_Repeatedly (anacran)_)
+    - driven by USB-event using udev (_When drive gets connected (udev)_).
+  - GUI Tests
+    - Open and all available dialogs, check how they look and if BIT might
+      crash.
+    - Additionally use `qt6ct` and repeat the tests.
+    - Try some fancy desktop environments (Mate, Budgie, …)
+    - As the cherry on top of the ice cream, check the translation of the GUI
+      in your native language(s).
 
 ## Other noteworthy things
 

qt/manageprofiles/tab_general.py

@@ -23,7 +23,6 @@
                              QLabel,
                              QLineEdit,
                              QMessageBox,
-                             QStyle,
                              QToolButton,
                              QToolTip,
                              QVBoxLayout,
@@ -576,14 +575,7 @@ def _cipher_combobox(self) -> combobox.BitComboBox:
         return combobox.BitComboBox(self, self.config.SSH_CIPHERS)
 
     def _create_label_encfs_deprecation(self):
-        # Icon
-        icon = self.style().standardIcon(
-            QStyle.StandardPixmap.SP_MessageBoxWarning)
-        size = self.style().pixelMetric(
-            QStyle.PixelMetric.PM_LargeIconSize)
-        icon_label = QLabel(self)
-        pixmap = icon.pixmap(size*2)
-        icon_label.setPixmap(pixmap)
+        icon_label = qttools.create_icon_label_warning()
 
         # encfs deprecation warning (see #1734, #1735)
         txt = _('EncFS profile creation will be removed in the next minor '

qt/manageprofiles/tab_remove_retention.py

@@ -17,7 +17,6 @@
                              QHBoxLayout,
                              QLabel,
                              QSpinBox,
-                             QStyle,
                              QToolTip,
                              QWidget)
 from PyQt6.QtCore import Qt
@@ -174,17 +173,7 @@ def update_items_state(self, enabled):
         self.cbSmartRemoveRunRemoteInBackground.setVisible(enabled)
 
     def _label_rule_execute_order(self) -> QWidget:
-        # Icon
-        icon = self.style().standardPixmap(
-            QStyle.StandardPixmap.SP_MessageBoxInformation)
-        icon = icon.scaled(
-            icon.width()*2,
-            icon.height()*2,
-            Qt.AspectRatioMode.KeepAspectRatio)
-
-        icon_label = QLabel(self)
-        icon_label.setPixmap(icon)
-        icon_label.setFixedSize(icon.size())
+        icon_label = qttools.create_icon_label_info(fixed_size_widget=True)
 
         # Info text
         txt = _(

qt/qttools.py

@@ -32,15 +32,17 @@
                           QLibraryInfo,
                           QT_VERSION_STR,
                           QUrl)
-from PyQt6.QtWidgets import (QWidget,
+from PyQt6.QtWidgets import (QAbstractItemView,
+                             QApplication,
+                             QDialog,
                              QFileDialog,
-                             QAbstractItemView,
+                             QLabel,
                              QListView,
-                             QTreeView,
-                             QDialog,
-                             QApplication,
+                             QSystemTrayIcon,
+                             QStyle,
                              QStyleFactory,
-                             QSystemTrayIcon)
+                             QTreeView,
+                             QWidget)
 
 from packaging.version import Version
 
@@ -185,6 +187,62 @@ def update_combo_profiles(config, combo_profiles, current_profile_id):
         if profile_id == current_profile_id:
             combo_profiles.set_current_profile_id(profile_id)
 
+
+def create_icon_label(
+        icon_type: QStyle.StandardPixmap,
+        icon_size: QStyle.PixelMetric = QStyle.PixelMetric.PM_LargeIconSize,
+        fixed_size_widget: bool = False) -> QLabel:
+    """Return a ``QLabel`` instance containing an icon.
+
+    Args:
+        icon_type: The icon, eg. info or warning.
+        icon_size: Size reference.
+        fixed_size_widget: Fix label size to its icon (default: False)
+
+    Returns:
+        The QLabel
+    """
+    style = QApplication.style()
+    ico = style.standardIcon(icon_type)
+    sz = style.pixelMetric(icon_size)
+
+    pixmap = ico.pixmap(sz)
+
+    label = QLabel()
+    label.setPixmap(pixmap)
+
+    if fixed_size_widget:
+        label.setFixedSize(pixmap.size())
+
+    return label
+
+
+def create_icon_label_info(
+        icon_size: QStyle.PixelMetric = QStyle.PixelMetric.PM_LargeIconSize,
+        fixed_size_widget: bool = False) -> QLabel:
+    """Return a QLabel with an info icon.
+
+    See `create_icon_label` for details.
+    """
+    return create_icon_label(
+        icon_type=QStyle.StandardPixmap.SP_MessageBoxInformation,
+        icon_size=icon_size,
+        fixed_size_widget=fixed_size_widget)
+
+
+def create_icon_label_warning(
+        icon_size: QStyle.PixelMetric = QStyle.PixelMetric.PM_LargeIconSize,
+        fixed_size_widget: bool = False) -> QLabel:
+    """Return a QLabel with a warning icon.
+
+    See `create_icon_label` for details.
+    """
+    return create_icon_label(
+        icon_type=QStyle.StandardPixmap.SP_MessageBoxWarning,
+        icon_size=icon_size,
+        fixed_size_widget=fixed_size_widget)
+
+
 # |---------------------|
 # | Misc / Uncatgorized |
 # |---------------------|