Skip to content

Commit e2f71ac

Browse files
committed
Merge branch 'dynamic_tree_transport' of github.com:bit-bots/dynamic_stack_decider into dynamic_tree_transport
2 parents a3f3c30 + 1112d7d commit e2f71ac

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

dynamic_stack_decider_visualization/dynamic_stack_decider_visualization/dsd_follower.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -216,9 +216,9 @@ def _stack_to_dotgraph(
216216
"""
217217
# Sanity check
218218
if stack_root is not None:
219-
assert stack_root["type"] == subtree_root["type"], "The stack and the tree do not match"
219+
assert stack_root["type"] == subtree_root["type"], "The stack root type and the tree root type do not match"
220220
if stack_root["type"] != "sequence":
221-
assert stack_root["name"] == subtree_root["name"], "The stack and the tree do not match"
221+
assert stack_root["name"] == subtree_root["name"], "The stack root name and the tree root name do not match"
222222

223223
# Generate dot node for the root and mark it as active if it is on the stack
224224
dot_node = DsdFollower._dot_node_from_tree_element(subtree_root, stack_root)
@@ -355,8 +355,9 @@ def to_q_item_model(self):
355355

356356
def destroy(self):
357357
"""
358-
Cleanup the subscriptions, to we don't receive any more data that we don't need (performance)
359-
Also this allows the garbage collector to delete this object and prevent memory leaks
358+
Cleanup the subscriptions, so we don't receive any more data that we don't need.
359+
This improves the performance.
360+
Also this allows the garbage collector to delete this object and prevent memory leaks.
360361
"""
361362
self._node.destroy_subscription(self.tree_sub)
362363
self._node.destroy_subscription(self.stack_sub)

dynamic_stack_decider_visualization/dynamic_stack_decider_visualization/dsd_visualization_plugin.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,11 +127,10 @@ def wheel_event(event):
127127
self._widget.auto_fit_graph_check_box.setChecked(False)
128128
self._widget.graphics_view.__class__.wheelEvent(self._widget.graphics_view, event)
129129

130-
# Call it as well as the original wheelEvent
130+
# Overwrite the original wheelEvent handler
131131
self._widget.graphics_view.wheelEvent = wheel_event
132132

133133
# Add widget to the user interface
134-
135134
context.add_widget(self._widget)
136135

137136
# Start a timer that calls back every 100 ms

0 commit comments

Comments
 (0)