Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request for permission to use the microphone #1842

Closed
HenrikJannsen opened this issue Mar 17, 2024 · 3 comments
Closed

Fix request for permission to use the microphone #1842

HenrikJannsen opened this issue Mar 17, 2024 · 3 comments
Assignees
Labels
Milestone

Comments

@HenrikJannsen
Copy link
Contributor

Users report that Bisq ask for permission to use the microphone.
On MacOS there is NSMicrophoneUsageDescription entry in Info.plist file. It is not clear why that entry is in there as it is not in our source code or build system. Probably a bad default value from jPackager.

  <key>NSMicrophoneUsageDescription</key>
  <string>The application Bisq 2 is requesting access to the microphone.</string>

Not sure if it is only on Mac requested or also other OS.

Anyway there is not reason to grant permission so users should reject that faulty request.

@HenrikJannsen HenrikJannsen added this to the 2.0.2 milestone Mar 17, 2024
@djing-chan djing-chan modified the milestones: 2.0.2, 2.0.3 Mar 27, 2024
@HenrikJannsen HenrikJannsen modified the milestones: 2.0.3, 2.0.4 Apr 9, 2024
@alvasw
Copy link
Contributor

alvasw commented Apr 26, 2024

We use jpackage to create packages that contain the JDK, so that users don't have to install Java separately. The JDK can't know in advance what APIs a Jar is consuming and requests therefore all permission by default.

The microphone permission is hard-coded here: https://github.com/openjdk/jdk/blob/master/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/Info-lite.plist.template#L36

I created a jpackage app image to modify the file but the jpackage app image creates the app bundle and there is no easy way to override the properties. At this point, It seems better to create the app bundle and runtime image ourselves to only request the permission we need.

@HenrikJannsen HenrikJannsen modified the milestones: 2.0.4, 2.0.5 May 10, 2024
@HenrikJannsen
Copy link
Contributor Author

Fixed by using a custom Info.plist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants