Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows installer missing "Launch Bisq 2" after installation #1574

Open
mrblue313 opened this issue Jan 7, 2024 · 5 comments
Open

Windows installer missing "Launch Bisq 2" after installation #1574

mrblue313 opened this issue Jan 7, 2024 · 5 comments

Comments

@mrblue313
Copy link
Contributor

It would be a much better experience if the option to launch Bisq 2 after installation was set to true by default.
As a user, you are expecting the application to launch.

@HenrikJannsen
Copy link
Contributor

Can you make a PR for adding that or do you need assistance from @alvasw ?

@mrblue313
Copy link
Contributor Author

You can assign it to me, I will check this.

@HenrikJannsen
Copy link
Contributor

Any update on that?

@djing-chan
Copy link
Contributor

djing-chan commented Feb 29, 2024

@mrblue313 We are close to release date. Any updates on that?
I added milestone 2.0.0, but it can be considered a "nice to have".

@djing-chan djing-chan added this to the 2.0.0 milestone Feb 29, 2024
@HenrikJannsen HenrikJannsen modified the milestones: 2.0.0, 2.0.1 Mar 4, 2024
@mrblue313
Copy link
Contributor Author

@HenrikJannsen - I looked into this a while back, apologies for not posting an update here.
The option to "Launch Bisq 2" immediately after installation is available once you enable resources. However, I see we have an issue with this, see commit.
If you uncomment that line you get the automatic launch. However, as of now, you end up suck with the installer and when clicking "Finish" or "Close" new instances of the app keep triggering and need to kill the installer process.
I think the issue should be changed to fix resources instead (seems like that will also apply to Bisq1).
Unfortunately, I'm not available to contribute to Bisq presently. I hope to be available in the forthcoming future.

@HenrikJannsen HenrikJannsen modified the milestones: 2.0.1, 2.0.3 Mar 12, 2024
@HenrikJannsen HenrikJannsen removed this from the 2.0.3 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants