Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailbox messages lost when performing SPV resync. #6367

Closed
ghost opened this issue Oct 2, 2022 · 0 comments · Fixed by #6376
Closed

Mailbox messages lost when performing SPV resync. #6367

ghost opened this issue Oct 2, 2022 · 0 comments · Fixed by #6376

Comments

@ghost
Copy link

ghost commented Oct 2, 2022

Description

When performing an SPV resync, any received mailbox messages will be tossed irretrievably into the void.

Version

All versions.

Steps to reproduce

  • Open mediation on a trade.
  • Go to Settings -> Network -> and press the SPV resync button.
  • Close Bisq.
  • Mediator issues a payout proposal which will be sent to you as a mailbox message.
  • Start Bisq to perform the SPV resync.
  • The payout proposal addressed to you will be silently ignored and removed from the network.

Expected behaviour

Mailbox messages should not be removed from the network when an SPV resync is happening.

Actual behaviour

The mailbox message addressed to you will be silently ignored and removed from the network.

Additional information

This happened to a user in the scenario outlined above, there are likely other examples of mailbox messages tossed when SPV resyncing, for example

  • payment started / confirmed.
  • trader/mediator chat messages.
  • any message / ticket sent to the support agent when the support agent is SPV resyncing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant